feat(etl): multi-period fundamentals ETL and PIT history - #116
Merged
Conversation
Record issue #87 delivery: annual/quarterly SimFin variants, QV field mapping, PIT history interface, and updated operator download table. Co-authored-by: Cursor <cursoragent@cursor.com>
Download annual/quarterly statement variants, normalize with QV field mapping and review-queue routing, and expose load_pit_fundamentals_history for per-period PIT queries without look-ahead. Closes #87 Co-authored-by: Cursor <cursoragent@cursor.com>
Cover phase 2 download variants, quarterly QV field normalization, missing-input review queue routing, and PIT history look-ahead guards. Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #116 +/- ##
===========================================
+ Coverage 97.87% 98.13% +0.26%
===========================================
Files 23 23
Lines 1552 1665 +113
Branches 192 216 +24
===========================================
+ Hits 1519 1634 +115
Misses 25 25
+ Partials 8 6 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Exercise PIT history edge paths, partition readers, statement matching, and YAML list parsing so Codecov patch coverage meets the threshold. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
download-simfinwith annual/quarterly income, balance, and cashflow SimFin bulk variants (phase 2, non-critical).accounts_receivable,cost_of_revenue,depreciation_amortization,sga_expense,operating_cash_flow) and route missing inputs to the review queue (missing_qv_inputs).load_pit_fundamentals_history()for per-fiscal-period PIT queries without look-ahead; Magic Formula loaders keep using TTM rows.Closes #87
Pre-commit gate
Test plan
poetry run pytest tests/test_download_simfin.py tests/test_simfin_normalizer.py tests/test_pit_fundamentals.pymake test(full suite, 236 passed)poetry run download-simfinwithSIMFIN_API_KEYto verify live annual/quarterly downloadspoetry run normalize-simfin --snapshot-date <date> --ticker AAPLafter downloadMade with Cursor