Skip to content

PR for #140 Automating PR reviews using GitHub Actions#141

Merged
liaochris merged 20 commits intomainfrom
140-automating-pr-reviews-using-github-actions
Mar 25, 2026
Merged

PR for #140 Automating PR reviews using GitHub Actions#141
liaochris merged 20 commits intomainfrom
140-automating-pr-reviews-using-github-actions

Conversation

@zhizhongpu
Copy link
Copy Markdown
Collaborator

No description provided.

@zhizhongpu zhizhongpu linked an issue Mar 18, 2026 that may be closed by this pull request
@zhizhongpu
Copy link
Copy Markdown
Collaborator Author

zhizhongpu commented Mar 18, 2026

List of documentation edits:

We should

  • flag that some tests under .github/ are GitHub Actions that ensure the repo's integrity, while others are there to automate the PR review process. Therefore, a user might want to delete the former set of Actions but not the latter when initializing a new repo.
  • say something about how to trigger GitHub Actions checks that we're adding via using e.g. a commit or a comment
    • Checks are together triggered by a commit if the commit's message contains [run-actions-all]
    • A check is triggered by a comment (/run-actions-all to run all, /run-actions-dag, /run-actions-newlines, /run-actions-eps, /run-actions-log to run individual tests).
      • adding parameter --post (e.g., commenting /run-actions-all --post) generates a new post with check results
  • say that GitHub Action checks have a default timeout of 60 seconds. To adjust this time, edit timeout-minutes in .github/workflows/checks.yml
  • modify workflow.md
    • to specify when during the PR review the GitHub Actions checks should be run using what triggers and by whom
    • consider the relationship between the sub-bullets under Assignees close the pull. vs the content of the posts (on the issue thread and the PR thread) posted by GitHub Actions upon PR closure. For example, the assignee should follow the checklist and check an item once and only once it's completed.
  • ?say something about the billing implications of using GitHub Actions if using the Template in a private repo

@zhizhongpu
Copy link
Copy Markdown
Collaborator Author

@liaochris feel free to edit #141 (comment) if there's anything else to add. Otherwise please tag JMS and say it's ready to be reviewed / acted on.

Comment thread .github/checks/check_eps_savefig.py
Comment thread .github/check_eps_savefig.py Outdated
Comment thread .github/readme_for_checks.md
Comment thread .github/post_template_pr_thread_pr_close.md Outdated
Comment thread README.md Outdated
@liaochris
Copy link
Copy Markdown
Collaborator

@zhizhongpu @jmshapir

In 46e8320 I improved the procedure and documentation for adding new checks so that

a) the procedure is more automated
b) the documentation is both more concise and provides a clear example

Copy link
Copy Markdown
Contributor

@jmshapir jmshapir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All my threads are resolved.

I left #141 (comment) open pending resolution and #141 (comment) open for visibility.

@zhizhongpu
Copy link
Copy Markdown
Collaborator Author

zhizhongpu commented Mar 25, 2026

I'm now taking a pass at the code @liaochris

@zhizhongpu
Copy link
Copy Markdown
Collaborator Author

I'm now taking a pass at the code @liaochris

@liaochris approving!

Excited to test it in a real project.

@liaochris liaochris merged commit b9ac5db into main Mar 25, 2026
16 checks passed
@liaochris
Copy link
Copy Markdown
Collaborator

summary comment

@liaochris liaochris deleted the 140-automating-pr-reviews-using-github-actions branch March 25, 2026 14:26
@github-actions
Copy link
Copy Markdown

@zhizhongpu Issue summary

Thanks for closing this pull.

Before leaving the pull, please be sure you have completed all the required steps in the workflow.

This includes filling in the issue summary linked at the top of this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automating PR reviews using GitHub Actions

3 participants