Potential fixes for issues #22, #20, and #19#23
Potential fixes for issues #22, #20, and #19#23
Conversation
…local machine or current user registry. need to figure out how to find other platforms through the registry then integrate into the main program
…all paths for that OS
… Was unable to test it and code got a bit hadouken-y so will definitely need input from someone with Moonlight/Sunshine to test and with more experience coding to optimize/clean up a bit
…mplementation a bit easier, which also helped with the hadouken
…to a function but it's late and i'm going to bed
… launchers that have a .exe of the same name in the steamapps/common folder that just launches the launcher - now it should find the larger of the two .exes first (the actual game launcher)
removed testing grounds for registry search now that the functionality is implemented into the main program
Windows registry paths
| Console.WriteLine(""); //blank line to separate platforms | ||
| } | ||
|
|
||
| string MakePathGooder(string path) |
There was a problem hiding this comment.
Rename with a more descriptive function name
| } | ||
| } | ||
| } | ||
| /*else if (path contains other installer keywords) |
| foreach (var drive in logicalDrives) | ||
| { | ||
| if (library is not VProperty libProp) | ||
| var libraryFoldersPath = drive.Name + steamLibraryFolders; |
There was a problem hiding this comment.
Can you add some comments explaining how the Vdf stuff works?
There was a problem hiding this comment.
Added comments to code - not sure if you meant here or there.
There was a problem hiding this comment.
Can you move all the files back to where they were originally?
There was a problem hiding this comment.
PublishProfiles and .pubxml were in the .gitignore - added back
| //@"*:\Program Files (x86)\Ubisoft\Ubisoft Game Launcher\games" | ||
| }; | ||
|
|
||
| var registryDir = new List<string>() |
There was a problem hiding this comment.
Remove these if they're not being used
There was a problem hiding this comment.
It is used - need to be declared for ScanFolder method to work, as well as the adding addlDirectories on line 60
|
|
||
| // default values | ||
| var gameDirs = new List<string>() { @"*:\Program Files (x86)\Steam\steamapps\common", @"*:\XboxGames", @"*:\Program Files\EA Games", @"*:\Program Files\Epic Games\", @"*:\Program Files (x86)\Ubisoft\Ubisoft Game Launcher\games" }; | ||
| var gameDirs = new List<string>() { |
There was a problem hiding this comment.
Remov these if they're not being used
There was a problem hiding this comment.
It is used - need to be declared for RegistrySearch method to work
| else | ||
| { | ||
| steamRegistry = Registry.CurrentUser.OpenSubKey(path); | ||
| if (steamRegistry != null && steamRegistry.GetValue("SteamPath") != null) |
There was a problem hiding this comment.
You can probably dedupe these 2 conditional blocks
|
@mikednjoy would love to revisit this PR soon |
2 participants
see discord for like nine paragraphs