fix(app): the stereo balance is readable again, and sits where people look - #586
Merged
Conversation
… look Three faults, one feature. The pair's master was never resolved. The agent sends that field as masterDeviceID and the app read st.master, so pair.master was empty on every pair and "ask the pair's MASTER for the balance" quietly asked whichever half happened to be selected. That is precisely what the earlier fix set out to do, so the balance stayed invisible for anyone who picked the other speaker, and the owner who reported it said so again on the very release that claimed to fix it. Both spellings are accepted now, so an older agent keeps working. It also sat next to the volume slider on the Play page, where it reads as a control that does nothing. It is a read-out: the firmware accepts no balance write that sticks. It now appears in Multi-Room, where a pair is made and undone, and in Speaker settings, with the reading and where the value can actually be changed as visible text rather than a tooltip nobody opens. And a stereo pair is no longer judged by /getZone. A pair is a firmware group made with /addGroup, and /getZone answers <zone /> for a healthy one, so the new liveness check reported a working pair as standalone six seconds after it was created. Caught on two SoundTouch 10s while testing. Release-Note: fix(app): the stereo balance of a pair is shown again, in Multi-Room and in the speaker settings Release-Note: fix(multiroom): a stereo pair is no longer reported as ungrouped moments after it is created Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W4ZJXsnpmJuazCKF6ijdcZ
JRpersonal
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three faults, one feature.
The pair's master was never resolved. The agent sends that field as
masterDeviceID and the app read st.master, so pair.master was empty on every
pair and "ask the pair's MASTER for the balance" quietly asked whichever half
happened to be selected. That is precisely what the earlier fix set out to do,
so the balance stayed invisible for anyone who picked the other speaker, and
the owner who reported it said so again on the very release that claimed to fix
it. Both spellings are accepted now, so an older agent keeps working.
It also sat next to the volume slider on the Play page, where it reads as a
control that does nothing. It is a read-out: the firmware accepts no balance
write that sticks. It now appears in Multi-Room, where a pair is made and
undone, and in Speaker settings, with the reading and where the value can
actually be changed as visible text rather than a tooltip nobody opens.
And a stereo pair is no longer judged by /getZone. A pair is a firmware group
made with /addGroup, and /getZone answers for a healthy one, so the
new liveness check reported a working pair as standalone six seconds after it
was created. Caught on two SoundTouch 10s while testing.
Release-Note: fix(app): the stereo balance of a pair is shown again, in Multi-Room and in the speaker settings
Release-Note: fix(multiroom): a stereo pair is no longer reported as ungrouped moments after it is created
Co-Authored-By: Claude Opus 5 (1M context) noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01W4ZJXsnpmJuazCKF6ijdcZ