docs(skills): correct the held-signal definition and document the blockedBy read field - #10068
Merged
Merged
Conversation
…ckedBy read field The gardening reference claimed `maintainer-only` + `roadmap` were a paired "held" signal that had to be added and removed together. That is wrong, and a gardening pass acted on it — flagging #7662, a correctly-labeled and genuinely contributor-open issue, as inconsistent because it carries `roadmap` without `maintainer-only`. The real held signals are the `maintainer-only` label, a JSONbored assignee, and the absence of a points-bearing `gittensor:*` label; any one of them holds an issue. `roadmap` is orthogonal and appears on both held and open issues, so it must never be added or stripped to change an issue's availability. This is the same filter the 50-100+ contributor-available floor is already computed with, so the doc now matches the measurement. Also documents that reading a dependency uses the `blockedBy` field, not `blockedByIssues` — the latter fails with an `undefinedField` error on `Issue` that reads like the dependency feature is unavailable on the repo, when only the field name differs from the already-documented `addBlockedBy` mutation.
Contributor
|
Important 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏳ LoopOver is waiting…LoopOver has seen this pull request and is waiting on CI checks to finish before reviewing it. This comment will update once the review runs. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed · 🟨 Waiting |
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two corrections to
.claude/skills/contributor-pipeline-gardening/reference.md. Doc-only — no code, no tests, no generated artifacts.1. The held-signal definition was wrong
The Labels section claimed
maintainer-only+roadmapwere a paired held signal that had to be added and removed together. They are not paired, androadmapis not a held signal at all.The real held signals are:
maintainer-onlylabel,gittensor:*label.Any one of them holds an issue.
roadmapis orthogonal and legitimately appears on both held and contributor-open issues.This is not theoretical: the 2026-07-31 gardening pass acted on the wrong rule and flagged #7662 — unassigned,
gittensor:feature, genuinely contributor-open — as having an inconsistent label set purely because it carriesroadmapwithoutmaintainer-only. Left unfixed, the next pass could have "corrected" that by addingmaintainer-only, silently removing a real issue from the contributor pool.The corrected text also states the availability filter explicitly, so the doc now matches the filter the 50-100+ floor is actually computed with.
2. Reading a dependency uses
blockedBy, notblockedByIssuesreference.mdalready documents theaddBlockedBymutation, but nothing said how to read the relationship.blockedByIssuesfails with a crypticundefinedFielderror ontype Issuethat reads like the whole dependency feature is unavailable on this repo. The correct field isblockedBy(inverse:blocking). Added with a working query, next to the existing-F query=@filegotcha, since sweeping it is how Pass 3 finds work whose blockers have all closed.Test Coverage
None applicable —
.claude/skills/**is documentation, outsidecoverage.includeand not executed by any suite.