fix(review): stop dedupeConcerns silently dropping blockers/nits past 20

[bitfathers94]

fix(review): stop dedupeConcerns silently dropping blockers/nits past 20

dedupeConcerns still capped its output at 20 with an undisclosed slice,
one layer above the disclosed-truncation stage dedupeLines got fixed to
in #9670. With more than 20 distinct blockers or nits the +N more
footer understated the hidden count, the AI-context block never saw
items past 20 despite promising every blocker, and the Nits sub-label
reported a number below the real deduped total. Remove the cap so
extractReviewSummary returns the full set and truncateFindingsForDisplay
is the only place truncation happens.

Closes #10010

[loopover-orb]

Tip

✅ LoopOver review result - approve/merge recommended

_{Review updated: 2026-07-31 07:09:05 UTC}

2 files · 1 AI reviewer · no blockers · readiness 93/100 · CI green · clean

✅ Suggested Action - Approve/Merge

• safe to merge

Review summary
This is a clean, narrow fix: dedupeConcerns' undisclosed `slice(0, 20)` cap is removed so extractReviewSummary returns the full deduped set, matching the pattern already established for dedupeLines in #9670, and pushing all truncation to the single disclosed stage at render time (truncateFindingsForDisplay). The change is a one-line diff plus a comment explaining the rationale, and is backed by five new tests that verify the full 30-item set survives buildUnifiedReviewInput, that the human-facing bullet list still caps at 12 with an accurate '+18 more' footer, that the AI-context block carries all 30, and that the Nits sub-label reports the true count. The reasoning traces correctly: with the cap removed, dedupeConcerns' output flows straight into truncateFindingsForDisplay (src/review/unified-comment.ts, further down in the file) which is now the only truncation point, so the fix is at the right layer.

Nits — 3 non-blocking

• The PR description says 'Closes orb(review): dedupeConcerns silently drops blockers/nits past 20, one layer above the disclosed-truncation fix #10010' but doesn't otherwise link/explain why this second layer was missed in orb(review): the unified comment's blocker list is silently capped at 12 #9670 — a one-line note in the PR body tying the two would help future readers, though the code comment already covers it.
• unified-comment.ts:121-122 — the doc comment references orb(review): dedupeConcerns silently drops blockers/nits past 20, one layer above the disclosed-truncation fix #10010 twice; consider a single canonical reference to avoid drift if the issue number is ever renumbered.
• Nothing further needed — the diff is minimal and the tests directly exercise the previously-broken path (30 items forcing the old 20-cap to trigger).

Decision drivers

• ✅ Code review — No blockers (1 reviewer)
• ✅ Gate result — Passing (No configured blocker found.)

Context & advisory signals — never blocks the verdict

Signal	Result	Evidence
Linked issue	✅ Linked	#10010
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (1 linked issue).
Validation posture	⚠️ 20/25	Preflight is ready, but the PR body does not name the validation run.
Contributor workload	✅ 10/10	Author activity: 98 registered-repo PR(s), 67 merged, 3 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	bitfathers94; Gittensor profile; 98 PR(s), 3 issue(s).
Improvement	✅ Minor	risk: clean · value: minor · LLM: moderate

Linked issue satisfaction

Addressed
The diff removes the `.slice(0, 20)` from dedupeConcerns exactly as required, mirroring dedupeLines' uncapped pattern, and adds tests confirming buildUnifiedReviewInput carries all 30 blockers/nits, renderUnifiedReviewComment shows 12 bullets with the correct '_+18 more_' footer, the AI-context block carries all 30 items, and the Nits sub-label reports 30.

Review context

• Author: bitfathers94
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: not available
• Official Gittensor activity: 98 PR(s), 3 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Start here: Add validation command/output.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

• @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
• @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
• A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

• Re-run LoopOver review

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.83%. Comparing base (0919f19) to head (f682675).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10102      +/-   ##
==========================================
+ Coverage   79.75%   79.83%   +0.08%     
==========================================
  Files         282      283       +1     
  Lines       58685    58958     +273     
  Branches     6878     7000     +122     
==========================================
+ Hits        46804    47072     +268     
- Misses      11593    11594       +1     
- Partials      288      292       +4     

Flag	Coverage Δ
backend	98.16% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/review/unified-comment.ts	98.16% <100.00%> (ø)

[loopover-orb]

LoopOver approves — the gate is satisfied and CI is green.