Skip to content

fix(ci): unbreak main — drop the orphaned AUTOMATION_COUNTED_ACTIONS export - #10111

Merged
JSONbored merged 1 commit into
mainfrom
fix/unbreak-main-dead-export
Jul 31, 2026
Merged

fix(ci): unbreak main — drop the orphaned AUTOMATION_COUNTED_ACTIONS export#10111
JSONbored merged 1 commit into
mainfrom
fix/unbreak-main-dead-export

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Closes #10109

dead-exports:check — part of test:ci — is red on a clean main, so every open PR inherits the failure and none can go green. Same class of breakage as #9944.

What was wrong

AUTOMATION_COUNTED_ACTIONS existed for exactly one consumer: the action IN (...) restriction in queryAutomationRows. #10013 removed that filter on purpose — the read now selects every verdict in the window, because a human signal (reevaluation_actor, reevaluation_reason = 'maintainer_request') can ride a non-deciding verdict such as a label or an update_branch, and the old filter dropped those rows so a PR a human had actually touched read as automated.

The fold still classifies enacted / held, but it tests AUTOMATION_ENACTING_ACTIONS and AUTOMATION_HOLD_ACTION separately — it needs to know which half matched, so the union is of no use to it. The symbol has had no reference of any kind since #10013; #10089 touched the file without re-homing it.

The change

Delete the export. Its one piece of real documentation — these two sets together are what DECIDES a PR — moves onto AUTOMATION_HOLD_ACTION, together with the reason there is deliberately no exported union: a constant naming a set nothing selects on invites the reader to believe the read still restricts by it, which is the exact misreading #10013 existed to correct. Leaving that unsaid is how the symbol would get reintroduced.

Verification

  • npm run dead-exports:checkno exported symbol is unreferenced outside its own file
  • npm run typecheck clean
  • test/unit/automation-rate.test.ts — 25 passed, file untouched. That is the evidence the symbol was load-bearing for nothing: no test needed adjusting, because no behaviour changed.

Zero runtime diff — the deleted line is a const no code path read.

@JSONbored JSONbored self-assigned this Jul 31, 2026
@JSONbored
JSONbored merged commit a1d0f67 into main Jul 31, 2026
2 checks passed
@JSONbored
JSONbored deleted the fix/unbreak-main-dead-export branch July 31, 2026 07:32
@loopover-orb

loopover-orb Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Important

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏳ LoopOver is waiting…

LoopOver has seen this pull request and is waiting on CI checks to finish before reviewing it. This comment will update once the review runs.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed · 🟨 Waiting

@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.07%. Comparing base (b900ef0) to head (7ce373e).
⚠️ Report is 9 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10111      +/-   ##
==========================================
- Coverage   91.94%   91.07%   -0.88%     
==========================================
  Files         930      930              
  Lines      113891   113890       -1     
  Branches    27492    27492              
==========================================
- Hits       104716   103721     -995     
- Misses       7877     9066    +1189     
+ Partials     1298     1103     -195     
Flag Coverage Δ
backend 94.12% <ø> (-1.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/review/automation-rate.ts 100.00% <ø> (ø)

... and 3 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: dead-exports:check is red on a clean main — AUTOMATION_COUNTED_ACTIONS has no consumer

1 participant