fix(ci): unbreak main — drop the orphaned AUTOMATION_COUNTED_ACTIONS export - #10111
Merged
Conversation
Contributor
|
Important 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏳ LoopOver is waiting…LoopOver has seen this pull request and is waiting on CI checks to finish before reviewing it. This comment will update once the review runs. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed · 🟨 Waiting |
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10111 +/- ##
==========================================
- Coverage 91.94% 91.07% -0.88%
==========================================
Files 930 930
Lines 113891 113890 -1
Branches 27492 27492
==========================================
- Hits 104716 103721 -995
- Misses 7877 9066 +1189
+ Partials 1298 1103 -195
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10109
dead-exports:check— part oftest:ci— is red on a cleanmain, so every open PR inherits the failure and none can go green. Same class of breakage as #9944.What was wrong
AUTOMATION_COUNTED_ACTIONSexisted for exactly one consumer: theaction IN (...)restriction inqueryAutomationRows. #10013 removed that filter on purpose — the read now selects every verdict in the window, because a human signal (reevaluation_actor,reevaluation_reason = 'maintainer_request') can ride a non-deciding verdict such as alabelor anupdate_branch, and the old filter dropped those rows so a PR a human had actually touched read as automated.The fold still classifies
enacted/held, but it testsAUTOMATION_ENACTING_ACTIONSandAUTOMATION_HOLD_ACTIONseparately — it needs to know which half matched, so the union is of no use to it. The symbol has had no reference of any kind since #10013; #10089 touched the file without re-homing it.The change
Delete the export. Its one piece of real documentation — these two sets together are what DECIDES a PR — moves onto
AUTOMATION_HOLD_ACTION, together with the reason there is deliberately no exported union: a constant naming a set nothing selects on invites the reader to believe the read still restricts by it, which is the exact misreading #10013 existed to correct. Leaving that unsaid is how the symbol would get reintroduced.Verification
npm run dead-exports:check→no exported symbol is unreferenced outside its own filenpm run typecheckcleantest/unit/automation-rate.test.ts— 25 passed, file untouched. That is the evidence the symbol was load-bearing for nothing: no test needed adjusting, because no behaviour changed.Zero runtime diff — the deleted line is a
constno code path read.