Skip to content

test(scoring): cover pending-pr helpers' ghost-login exclusion and case-insensitive matching #8468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jeffrey701 wants to merge 1 commit into from
+18 −0
Closed

test(scoring): cover pending-pr helpers' ghost-login exclusion and case-insensitive matching #8468

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions test/unit/pending-pr-scenarios.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,4 +461,22 @@ describe("pending PR scenario detection", () => {
expect(records.pullRequestChecks).toHaveLength(0);
vi.restoreAllMocks();
});

// #8329: exercise both branches of sameLogin's `value &&` short-circuit and the case-insensitive matching of
// sameRepoFullName/sameLogin — a ghost/deleted account (null/undefined authorLogin) must be excluded, while a
// repoFullName or login that differs only in letter case must still match.
it("excludes null/undefined authorLogin and matches case-insensitively on repo and login", async () => {
const env = {} as Env;
vi.spyOn(repositories, "listPullRequestReviews").mockImplementation(async (_env, _repo, pullNumber) => [approvedReview(pullNumber)]);
vi.spyOn(repositories, "listCheckSummaries").mockResolvedValue([]);
const records = await loadContributorRepoOpenPrSignalRecords(env, "entrius/allways-ui", "miner-a", [
pr({ number: 80, authorLogin: null }), // ghost account → sameLogin short-circuits to excluded
pr({ number: 81, authorLogin: undefined }), // deleted account → excluded
pr({ number: 82, repoFullName: "Entrius/Allways-UI" }), // repo differs only in case → still matches
pr({ number: 83, authorLogin: "Miner-A" }), // login differs only in case → still matches
]);
// Only the two case-differing (but genuinely matching) PRs are counted; both ghost-account PRs are excluded.
expect(records.pullRequestReviews.map((review) => review.pullNumber).sort((a, b) => a - b)).toEqual([82, 83]);
vi.restoreAllMocks();
});
});
Loading