test(miner): mirror shouldReenter under root vitest for Codecov (#8347)

[claytonlin1110]

Summary

• Add test/unit/loop-reentry-policy.test.ts, a root vitest mirror of the existing engine node:test suite for shouldReenter, so Codecov can see packages/loopover-engine/src/miner/loop-reentry-policy.ts.
• Document the mirror in packages/loopover-engine/README.md — same pattern as reviewer-consensus-calibration.ts (658 lines) is the package's largest branch surface invisible to Codecov #8349 — so the engine path filter trips and CI runs the unscoped suite. A test-only diff under scoped --changed writes empty lcov and fails validate-tests-merge (exactly what closed test(miner): mirror shouldReenter ceilings under root vitest for Codecov (#8347) #8460).
• No changes under packages/loopover-engine/src/** or packages/loopover-engine/test/**.

Closes #8347

Scope

• The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
• This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
• This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
• I linked a currently open issue this PR resolves (e.g. Closes #123) — a linked open issue is required for every contributor PR.

Validation

• git diff --check
• npm run actionlint
• npm run typecheck
• npm run test:coverage locally; codecov/patch requires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.
• npm run test:workers
• npm run build:mcp
• npm run test:mcp-pack
• npm run ui:openapi:check
• npm run ui:lint
• npm run ui:typecheck
• npm run ui:build
• npm audit --audit-level=moderate
• New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

• Test + engine README note only. Locally verified: npx vitest run test/unit/loop-reentry-policy.test.ts (17 pass), coverage of loop-reentry-policy.ts at 100% stmts/branches/lines, npm run typecheck, git diff --check, npm audit --audit-level=moderate. README change sets engine=true so CI runs the full unscoped suite (avoids the test(miner): mirror shouldReenter ceilings under root vitest for Codecov (#8347) #8460 empty-lcov / missing all-blob-reports failure). Remaining validate-code steps unchanged by this diff.

Safety

• No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
• Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
• Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
• API/OpenAPI/MCP behavior is updated and tested where needed.
• UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
• Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
• Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

N/A — test-only, no visible UI change.

State / title	JPG/PNG evidence
N/A

Notes

• Fresh PR after test(miner): mirror shouldReenter ceilings under root vitest for Codecov (#8347) #8460 was auto-closed on validate-tests-merge (ENOENT: all-blob-reports): scoped --changed ran the new test, then skipped blob upload because coverage/lcov.info was empty (no_src_coverage), so merge had nothing to scan.
• Same remediation as the successful reviewer-consensus-calibration.ts (658 lines) is the package's largest branch surface invisible to Codecov #8349 retry: engine README note → engine=true → unscoped suite.

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.49%. Comparing base (8dffb03) to head (2e7584d).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8479      +/-   ##
==========================================
+ Coverage   92.47%   92.49%   +0.02%     
==========================================
  Files         791      791              
  Lines       79321    79335      +14     
  Branches    23954    23965      +11     
==========================================
+ Hits        73355    73384      +29     
+ Misses       4839     4807      -32     
- Partials     1127     1144      +17     

Flag	Coverage Δ
shard-1	57.05% <ø> (-0.98%)	⬇️
shard-2	50.98% <ø> (+0.90%)	⬆️
shard-3	54.05% <ø> (-0.34%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 5 files with indirect coverage changes

[loopover-orb]

Tip

✅ LoopOver review result - approve/merge recommended

_{Review updated: 2026-07-24 15:19:17 UTC}

2 files · 1 AI reviewer · no blockers · readiness 93/100 · CI green · clean

✅ Suggested Action - Approve/Merge

• safe to merge

Review summary
This is a test-only PR that adds a root vitest mirror of the existing engine node:test suite for `shouldReenter`, plus a one-line README doc update, so Codecov's patch coverage can see `packages/loopover-engine/src/miner/loop-reentry-policy.ts` and the unscoped test suite runs in CI. The test suite is thorough — it covers kill-switch precedence, the circuit-breaker's `&&` short-circuit in both directions, all three rate/session caps at and below their ceilings, default-vs-override threshold behavior, and multi-reason aggregation — matching the stated intent and the established pattern from #8349/#8346. All CI checks passed and the change touches no production code under `src/**` or `test/**`.

Nits — 2 non-blocking

• The `baseCandidate` overrides type comes from `LoopReentryCandidate` imported from `../../packages/loopover-engine/src/index`, a relative cross-package import rather than the `@​loopover/engine` package alias used elsewhere (e.g. in `packages/loopover-miner/lib/loop-reentry.ts`) — worth confirming this matches the pattern used by the other root-vitest mirrors (reviewer-consensus-calibration.ts (658 lines) is the package's largest branch surface invisible to Codecov #8349, miner/harness-submission-trigger.ts's circuit-breaker logic is invisible to Codecov #8346) rather than introducing a new import style.
• Consider verifying that `test/unit/loop-reentry-policy.test.ts` imports the same way as the sibling mirrors (`test/unit/harness-submission-trigger.test.ts`, etc.) for consistency.

Decision drivers

• ✅ Code review — No blockers (1 reviewer)
• ✅ Gate result — Passing (No configured blocker found.)

Context & advisory signals — never blocks the verdict

Signal	Result	Evidence
Linked issue	✅ Linked	#8460, #8347
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (2 linked issues).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 406 registered-repo PR(s), 254 merged, 92 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	claytonlin1110; Gittensor profile; 406 PR(s), 92 issue(s).
Improvement	ℹ️ Insufficient signal	risk: clean · value: insufficient-signal · LLM: moderate

Linked issue satisfaction

Addressed
The PR adds a root vitest mirror (test/unit/loop-reentry-policy.test.ts) that exercises shouldReenter with comprehensive coverage of kill-switch, circuit-breaker, and rate-cap paths, directly satisfying the issue's ask to make packages/loopover-engine/src/miner/loop-reentry-policy.ts visible to Codecov's root-scoped suite, and also documents the mirror pattern in the engine README to ensure CI pat

Review context

• Author: claytonlin1110
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: Python, JavaScript, TypeScript, Rust
• Official Gittensor activity: 406 PR(s), 92 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Start here: Triage stale or unlinked PRs.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

• @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
• @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
• A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

• Re-run LoopOver review

[loopover-orb]

LoopOver approves — the gate is satisfied and CI is green.