fix(queue): record gate_check_run in failedOutputs on double failure

[joaovictor91123]

Summary

• When a gate_check_run primary publish and its createOrUpdateErroredGateCheckRun fallback both fail, push gate_check_run onto failedOutputs (same contract as check_run / comment / label).
• Gate-only repos now correctly fire pr_public_surface_failed, PostHog escalation, and RetryablePublicSurfacePublishFailedError on transient double-failure.
• Updates the prior gate-only incomplete-surface test that assumed empty failedOutputs (that was the bug fix(orb): gate_check_run publish failures never populate failedOutputs, unlike check_run/comment/label #8686 fixes) so validate-tests stays green - the failure mode that closed fix(queue): record gate_check_run in failedOutputs on double failure #8734.

Closes #8686

Scope

• The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
• This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
• This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
• I linked a currently open issue this PR resolves (e.g. Closes #123) - a linked open issue is required for every contributor PR.

Validation

• git diff --check
• npm run actionlint
• npm run typecheck
• npm run test:coverage locally; codecov/patch requires ?99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.
• npm run test:workers
• npm run build:mcp
• npm run test:mcp-pack
• npm run ui:openapi:check
• npm run ui:lint
• npm run ui:typecheck
• npm run ui:build
• npm audit --audit-level=moderate
• New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

• Local Node is v24; repo engines pin Node 22. New/updated coverage is in test/unit/queue-4.test.ts and will run under CI. fix(queue): record gate_check_run in failedOutputs on double failure #8734 failed validate-tests on the outdated incomplete-surface expectation - fixed here.

Safety

• No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
• Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
• Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
• API/OpenAPI/MCP behavior is updated and tested where needed.
• UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
• Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
• Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

N/A - no visible UI changes.

Notes

• Replaces closed fix(queue): record gate_check_run in failedOutputs on double failure #8734. Fallback publish behavior unchanged; only final double-failure recording into failedOutputs is added.

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.19%. Comparing base (6735ef1) to head (499593c).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8739      +/-   ##
==========================================
+ Coverage   90.56%   91.19%   +0.63%     
==========================================
  Files          96       97       +1     
  Lines       22490    25678    +3188     
  Branches     3884     5017    +1133     
==========================================
+ Hits        20367    23416    +3049     
- Misses       1945     1994      +49     
- Partials      178      268      +90     

Flag	Coverage Δ
backend	95.63% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/queue/processors.ts	95.63% <100.00%> (ø)

[loopover-orb]

Tip

✅ LoopOver review result - approve/merge recommended

_{Review updated: 2026-07-26 05:31:59 UTC}

2 files · 1 AI reviewer · no blockers · readiness 95/100 · CI green · clean

✅ Suggested Action - Approve/Merge

• safe to merge

Review summary
This PR closes #8686 by making the gate_check_run publish path push a failedOutputs entry when both the primary publish and its errored-fallback fail, mirroring the existing check_run/comment/label contract so gate-only repos correctly escalate to pr_public_surface_failed/PostHog/transient retry instead of silently leaving failedOutputs empty. The two new `!gateFinalized` guards are placed at the two call sites where gateFinalized would otherwise remain false after a double failure, and the diff updates/adds tests that exercise the real double-403 and double-500 paths (not fabricated states) plus asserts on audit metadata and the PostHog capture call. This is a narrowly-scoped, well-targeted bugfix with matching test coverage for both the permission_missing (non-transient) and API-failure (transient) branches.

Nits — 4 non-blocking

• The `fix(orb): gate_check_run publish failures never populate failedOutputs, unlike check_run/comment/label #8686` inline comments in src/queue/processors.ts:10813 and :10863 are fairly long block comments explaining historical context — consider trimming to the non-obvious 'why' only, per repo convention of terse comments.
• The first modified test (queue-4.test.ts) drops the previous audit-write-failure coverage entirely rather than adding the new scenario alongside it — worth double-checking that behavior (audit write failure during incomplete-surface) is still covered elsewhere.
• Consider factoring the repeated `failedOutputs.push({ output: "gate_check_run", ... })` block (appearing twice, at 10813 and 10863) into a small local helper to avoid drift between the two call sites, similar to how check_run/comment/label presumably share one shape.
• Double-check that `gateFinalized` can never be true after an exception path reaches the second block — if it can, the added guard is dead code.

Decision drivers

• ✅ Code review — No blockers (1 reviewer)
• ✅ Gate result — Passing (No configured blocker found.)

Context & advisory signals — never blocks the verdict

Signal	Result	Evidence
Linked issue	✅ Linked	#8734, #8686
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (2 linked issues).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 171 registered-repo PR(s), 76 merged, 5 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	joaovictor91123; Gittensor profile; 171 PR(s), 5 issue(s).
Improvement	✅ Minor	risk: clean · value: minor

Linked issue satisfaction

Addressed
The diff adds failedOutputs.push({output: "gate_check_run", ...}) in both the primary-catch and no-fallback branches of maybePublishPrPublicSurface, matching the check_run/comment/label contract, and adds/updates queue tests covering permission_missing and transient double-failure paths that assert pr_public_surface_failed, PostHog escalation, and retryable transient errors fire.

Review context

• Author: joaovictor91123
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: Python, JavaScript, MDX, TypeScript, C++, CSS, Rust
• Official Gittensor activity: 171 PR(s), 5 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Start here: Triage stale or unlinked PRs.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

• @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
• @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
• A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

• Re-run LoopOver review

[loopover-orb]

LoopOver approves — the gate is satisfied and CI is green.

[loopover-orb]

LoopOver approves — the gate is satisfied and CI is green.