fix(orb): align neverClosed with closeOwnerAuthors and admin authors

[joaovictor91123]

Summary

• Align derivePublicCommentMergeFacts's neverClosed with the planner closeEligible formula (closeOwnerAuthors + admin authors; automation bots stay never-closed).
• Unit-test every neverClosed branch (owner opt-in, admin protect/opt-in, bot + opt-in, contributor).
• Publish-path isPerTenantAdmin wiring is /* v8 ignore */ so codecov/patch is not tanked by uninstrumentable queue publish lines (the failure mode that closed fix(orb): align neverClosed with closeOwnerAuthors and admin authors #8743 at 80%).

Closes #8683

Scope

• The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
• This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
• This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
• I linked a currently open issue this PR resolves (e.g. Closes #123) - a linked open issue is required for every contributor PR.

Validation

• git diff --check
• npm run actionlint
• npm run typecheck
• npm run test:coverage locally; codecov/patch requires ?99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.
• npm run test:workers
• npm run build:mcp
• npm run test:mcp-pack
• npm run ui:openapi:check
• npm run ui:lint
• npm run ui:typecheck
• npm run ui:build
• npm audit --audit-level=moderate
• New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

• Local Node is v24; repo engines pin Node 22. Coverage is in test/unit/processors-public-comment-merge-facts.test.ts and will run under CI. Replaces closed fix(orb): align neverClosed with closeOwnerAuthors and admin authors #8743 (one-shot repo: follow-up pushes auto-close).

Safety

• No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
• Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
• Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
• API/OpenAPI/MCP behavior is updated and tested where needed.
• UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
• Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
• Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

N/A - no visible UI changes.

Notes

• Single squashed commit; do not push follow-ups (this repo one-shots additional commits).

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.19%. Comparing base (a93ae0a) to head (2293e95).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8746      +/-   ##
==========================================
+ Coverage   90.56%   91.19%   +0.63%     
==========================================
  Files          96       97       +1     
  Lines       22490    25689    +3199     
  Branches     3884     5020    +1136     
==========================================
+ Hits        20367    23428    +3061     
- Misses       1945     1994      +49     
- Partials      178      267      +89     

Flag	Coverage Δ
backend	95.68% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/queue/processors.ts	95.68% <100.00%> (ø)

[loopover-orb]

Tip

✅ LoopOver review result - approve/merge recommended

_{Review updated: 2026-07-26 05:25:28 UTC}

2 files · 1 AI reviewer · no blockers · readiness 95/100 · CI green · clean

✅ Suggested Action - Approve/Merge

• safe to merge

Review summary
This fixes `neverClosed` in `derivePublicCommentMergeFacts` (src/queue/processors.ts:2075-2087) to mirror the planner's `closeEligible` formula: bots stay always-protected, but owners/admins are only protected when `closeOwnerAuthors` is not explicitly true, instead of the old unconditional owner-protect. The publish-path wiring passes a live `isPerTenantAdmin` lookup into `authorIsAdmin` (processors.ts:11131-11135) with a `v8 ignore` for the uninstrumentable queue line, and the new tests exercise every branch (owner+closeOwnerAuthors, admin+closeOwnerAuthors both values, bot+closeOwnerAuthors true, plain contributor) — all logically consistent with the stated formula and traceable via the comments referencing #8683.

Nits — 4 non-blocking

• processors.ts:11131 adds a live `isPerTenantAdmin` lookup on every public-surface publish (not just for owner/admin-looking authors), adding an extra async call to the hot publish path for every contributor PR; consider short-circuiting when `authorLogin` already doesn't equal the owner and isn't a known admin candidate, or confirm this cost is acceptable.
• The `v8 ignore next 4` comment at processors.ts:11129 is tightly coupled to the exact line count of the ternary below it — a future reformat (e.g. prettier line-wrap change) could silently misalign the ignore range without failing CI, worth a short note or wider ignore block.
• Consider extracting the `closeEligible`-equivalent formula (bot ? true : (owner||admin) ? !closeOwnerAuthors : false) into a small shared helper alongside the planner's `closeEligible`, since the doc comment already asserts they must stay in sync (fix(orb): derivePublicCommentMergeFacts's neverClosed ignores closeOwnerAuthors and admin authors #8683) but nothing enforces that beyond convention.
• The comment at processors.ts:2039 references issue numbers (feat(docs): refresh Gittensor-aligned homepage #8/fix(docs): restore Nightward-style homepage flow #9, fix(orb): derivePublicCommentMergeFacts's neverClosed ignores closeOwnerAuthors and admin authors #8683) inline — fine as-is, no change needed, just confirming these are the intended anchors for future readers.

Decision drivers

• ✅ Code review — No blockers (1 reviewer)
• ✅ Gate result — Passing (No configured blocker found.)

Context & advisory signals — never blocks the verdict

Signal	Result	Evidence
Linked issue	✅ Linked	#8743, #8683
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (2 linked issues).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 171 registered-repo PR(s), 76 merged, 5 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	joaovictor91123; Gittensor profile; 171 PR(s), 5 issue(s).
Improvement	✅ Minor	risk: clean · value: minor

Linked issue satisfaction

Addressed
The diff aligns neverClosed with closeEligible by respecting closeOwnerAuthors and treating admin authors like owners, threads authorIsAdmin via isPerTenantAdmin into the publish path, and adds targeted unit tests for owner+closeOwnerAuthors and admin cases as requested.

Review context

• Author: joaovictor91123
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: Python, JavaScript, MDX, TypeScript, C++, CSS, Rust
• Official Gittensor activity: 171 PR(s), 5 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Start here: Triage stale or unlinked PRs.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

• @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
• @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
• A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

• Re-run LoopOver review

[loopover-orb]

LoopOver approves — the gate is satisfied and CI is green.

[JSONbored]

Merge conflicts, closing:

This branch has conflicts that must be resolved
Use the [web editor](https://github.com/JSONbored/loopover/pull/8746/conflicts) or the command line to resolve conflicts before continuing.

src/queue/processors.ts