Skip to content

fix(miner): reject a portfolio-queue identifier containing the '::' composite-id separator (#8857) #8925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loopover-orb merged 2 commits into from
Jul 26, 2026
+17 −0
Merged

fix(miner): reject a portfolio-queue identifier containing the '::' composite-id separator (#8857) #8925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba06639
fix(miner): reject a portfolio-queue identifier containing the '::' c…
Jul 26, 2026
ad25f33
Merge branch 'main' into fix/critical-issue-queueitem-id-separator-8857
loopover-orb[bot] Jul 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/loopover-miner/lib/portfolio-queue.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,11 @@ function normalizeIdentifier(identifier: unknown): string {
if (typeof identifier !== "string") throw new Error("invalid_identifier");
const trimmed = identifier.trim();
if (!trimmed) throw new Error("invalid_identifier");
// portfolio-queue-manager's composite queueItemId joins apiBaseUrl/repoFullName/identifier on "::"
// (ITEM_ID_SEPARATOR). repoFullName is "::"-free by isValidRepoSegment, but identifier had no such guard: an
// identifier containing "::" would silently corrupt the parsed apiBaseUrl/repoFullName/identifier triple.
// Reject it at construction rather than encode-and-hope (#8857).
if (trimmed.includes("::")) throw new Error("invalid_identifier");
return trimmed;
}

Expand Down
12 changes: 12 additions & 0 deletions test/unit/miner-portfolio-queue-manager.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,18 @@ describe("entriesToPortfolioQueue() / selectEligibleBatch() (#4285)", () => {
expect(() => parseQueueItemId("https://api.github.com::::issue:7")).toThrow("invalid_queue_item_id");
});

it("queueItemId/parseQueueItemId round-trip an identifier that does NOT contain the '::' separator (#8857)", () => {
const id = queueItemId("https://api.github.com", "acme/widgets", "issue:5");
expect(parseQueueItemId(id)).toEqual({ apiBaseUrl: "https://api.github.com", repoFullName: "acme/widgets", identifier: "issue:5" });
});

it("rejects an identifier containing the '::' separator at enqueue time, preventing silent id corruption (#8857)", () => {
const manager = memoryManager({ globalWipCap: 4, perRepoWipCap: 2 });
expect(() => manager.enqueue({ repoFullName: "acme/widgets", identifier: "issue::5", apiBaseUrl: "https://api.github.com" })).toThrow("invalid_identifier");
// A single-colon identifier is still accepted — the invariant only forbids the "::" join sequence itself.
expect(manager.enqueue({ repoFullName: "acme/widgets", identifier: "issue:5", apiBaseUrl: "https://api.github.com" }).identifier).toBe("issue:5");
});

it("entriesToPortfolioQueue falls back to the github.com default when a row's apiBaseUrl is missing (#5563)", () => {
const entries = [
{ repoFullName: "acme/alpha", identifier: "x", priority: 0, status: "queued", enqueuedAt: "t1" },
Expand Down