fix(integrations): raise the comment-marker search page cap to match comments.ts - #8947
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
…comments.ts project-tracker-adapter.ts's marker search reused GITHUB_LIST_PAGE_LIMIT = 3, but comments.ts's sibling COMMENT_SEARCH_PAGE_LIMIT was bumped 3 -> 10 (JSONbored#7232) precisely because a >300-comment thread let the marker hide and caused a duplicate post. This file was never updated, so maybeSuggestProjectOrMilestoneMatch could still double-post its marker comment on any PR/issue with >300 comments. Introduce a dedicated COMMENT_MARKER_SEARCH_PAGE_LIMIT = 10 for the marker search (the milestone/project list searches keep the 3-page bound). Closes JSONbored#8889 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8947 +/- ##
==========================================
+ Coverage 90.56% 90.61% +0.05%
==========================================
Files 96 97 +1
Lines 22490 22626 +136
Branches 3884 3920 +36
==========================================
+ Hits 20367 20503 +136
Misses 1945 1945
Partials 178 178
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Warning ⏸️ LoopOver review result - manual review recommendedReview updated: 2026-07-26 14:20:27 UTC
Review summary Nits — 3 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. Decision record
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Summary
project-tracker-adapter.ts's comment-marker search reusedGITHUB_LIST_PAGE_LIMIT = 3, butcomments.ts's siblingCOMMENT_SEARCH_PAGE_LIMITwas bumped3 -> 10(#7232, commit18fe74628)specifically because a >300-comment thread let the marker hide and caused a duplicate post. This file
was never updated, so
maybeSuggestProjectOrMilestoneMatchcould still double-post thePROJECT_TRACKER_SUGGEST_COMMENT_MARKERcomment on any PR/issue with >300 comments.Introduces a dedicated
COMMENT_MARKER_SEARCH_PAGE_LIMIT = 10for the marker-search path, matchingcomments.ts. The milestone/project list searches keep the 3-page bound (only marker detectionneeds the deeper scan to stay double-post-safe).
Test plan
maybeSuggestProjectOrMilestoneMatchreturns{ suggested: false }and never POSTsnpx vitest run test/unit/project-tracker-adapter.test.ts— 54/54 pass;tsc --noEmitcleanCloses #8889