fix(engine): align no-preference miner lane-fit score to 0.5 - #8981
Closed
joaovictor91123 wants to merge 1 commit into
Closed
fix(engine): align no-preference miner lane-fit score to 0.5#8981joaovictor91123 wants to merge 1 commit into
joaovictor91123 wants to merge 1 commit into
Conversation
computeMinerGoalLaneFit returned 1 when preferredLabels were empty; match computeLaneFit's documented neutral of 0.5 so metadata ranking does not over-weight unconfigured goals. Closes JSONbored#8870
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Contributor
Author
|
Closing per contributor focus shift away from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
computeMinerGoalLaneFit's empty-preferredLabelsbranch to return0.5, matchingcomputeLaneFit's documented neutral (never 0 or 1).node:testand vitest coverage that pinned the old1behavior.Closes #8870
Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Closes #123) — a linked open issue is required for every contributor PR.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally;codecov/patchrequires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateIf any required check was skipped, explain why:
Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.UI Evidence
N/A — no visible UI changes.
Notes
miner-worktree-allocator-collisionsflake.