fix(engine): weight local-scorer totalTokenScore with TEST_FILE_CONTRIBUTION_WEIGHT - #9095
Conversation
…IBUTION_WEIGHT (JSONbored#8875) Apply the same test-file discount preview.ts uses when deriving totalTokenScore so feeding localScorer totals back into buildScorePreview no longer bypasses the gate's contribution-bonus weighting on test-heavy diffs. Co-authored-by: Cursor <cursoragent@cursor.com>
…SONbored#8875) Co-authored-by: Cursor <cursoragent@cursor.com>
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
|
Caution 🛑 LoopOver review result - fixes requiredReview updated: 2026-07-26 17:33:32 UTC
Review summary Nits — 1 non-blocking
CI checks failing
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
|
LoopOver is closing this pull request on the maintainer's behalf (CI is failing (validate, validate-tests)). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed. |
Summary
computeLocalScorerTokensnow derivestotalTokenScorewithTEST_FILE_CONTRIBUTION_WEIGHT(same formula aspreview.ts'sderivedTotalTokenScore) instead of a raw unweighted line sum.buildScorePreviewwhen the explicit total is fed back vs when preview derives it from components.mcp-cli-plan-scorer-tools,mcp-run-local-scorer) that previously expected the old raw sum — the gap that closed fix(engine): weight local-scorer totalTokenScore with TEST_FILE_CONTRIBUTION_WEIGHT #8970/fix(engine): weight local-scorer totalTokenScore with TEST_FILE_CONTRIBUTION_WEIGHT #8977.Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Closes #123) — a linked open issue is required for every contributor PR.Validation
git diff --checknpx vitest run test/unit/local-scorer.test.ts— 7 passednpm run test --workspace @loopover/engine -- test/local-scorer.test.ts— passednpx vitest run test/unit/mcp-cli-plan-scorer-tools.test.ts -t "loopover_run_local_scorer computes"— passedpackages/loopover-engine/src/local-scorer.tsnpm run typechecknpm run actionlintnpm run test:coveragenpm audit --audit-level=moderateIf any required check was skipped, explain why:
Narrow engine scoring alignment fix; full
test:cileft for CI. Targeted local-scorer + MCP tool tests cover the weighted total and preview agreement path.Notes for reviewers / gate
site/,CNAME,**/lovable/**, orCHANGELOG.md.Made with Cursor