fix(engine): compare maxIterations and percentComplete in progressChanged - #9332
Closed
philluiz2323 wants to merge 1 commit into
Closed
fix(engine): compare maxIterations and percentComplete in progressChanged#9332philluiz2323 wants to merge 1 commit into
philluiz2323 wants to merge 1 commit into
Conversation
…nged progressChanged only compared phase/status/iteration/activity, so raising maxIterations mid-run changed percentComplete without triggering a customer-facing push. Compare both displayed budget axes alongside the existing fields. Closes JSONbored#9323
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (50.00%) is below the target coverage (99.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #9332 +/- ##
==========================================
- Coverage 75.38% 75.38% -0.01%
==========================================
Files 275 275
Lines 58023 58026 +3
Branches 6181 6181
==========================================
+ Hits 43739 43740 +1
- Misses 14014 14016 +2
Partials 270 270
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Contributor
Author
|
Closing: engine patch coverage requires packages/loopover-engine tests; re-scoping. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closes #9323.
progressChangedcompared phase, status, iteration, and the activity tail — but notmaxIterationsorpercentComplete. When an operator raised the iteration budget mid-run while those other axes stayed the same, the customer-facing progress bar went stale because no push was emitted.Fix
Include
maxIterationsandpercentCompletein theprogressChangedcomparison, matching the displayed snapshot axes.Tests
maxIterations.maxIterationsfrom 5→10 at the same iteration pushes even when activity is unchanged.Reverting either comparison fails the regression test.
git diff --checkclean.Validation
vitest run test/unit/loop-progress.test.ts(14 pass)Safety