Skip to content

fix(signals): render discouragedPaths in onboarding-pack preview markdown #9336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loopover-orb merged 1 commit into from
Jul 27, 2026
+21 −0
Merged

fix(signals): render discouragedPaths in onboarding-pack preview markdown #9336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/signals/onboarding-pack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,7 @@ function buildPreviewMarkdown(preview: RepoOnboardingPackPreview): string {
preview.contributionLanes.forEach((lane) => {
lines.push(`- ${lane.title}: ${lane.summary}`);
appendNestedList(lines, "Preferred paths", lane.preferredPaths);
appendNestedList(lines, "Discouraged paths", lane.discouragedPaths);
appendNestedList(lines, "Validation", lane.validationExpectations);
appendNestedList(lines, "Notes", lane.publicNotes);
});
Expand Down
20 changes: 20 additions & 0 deletions test/unit/onboarding-pack.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,11 +96,31 @@ describe("buildRepoOnboardingPackPreview", () => {
"Confirm contribution guidance stays previewable before publication.",
);
expect(preview.previewMarkdown).toContain("Direct PR quality lane");
expect(preview.previewMarkdown).toContain("Discouraged paths: scripts/release/");
expect(preview.previewMarkdown).toContain("Label policy");
expect(preview.previewMarkdown).toContain("Validation expectations");
expect(preview.previewMarkdown).toContain("Readiness warnings");
});

it("omits the Discouraged paths lane entry when discouragedPaths is empty", () => {
const preview = buildRepoOnboardingPackPreview({
...POLICY_COMPILER_FIXTURE,
contributionLanes: [
{
id: "docs-lane",
title: "Docs lane",
summary: "Documentation-only improvements.",
preferredPaths: ["docs/"],
discouragedPaths: [],
validationExpectations: ["Run npm run test:ci before submission."],
},
],
});

expect(preview.previewMarkdown).toContain("Preferred paths: docs/");
expect(preview.previewMarkdown).not.toContain("Discouraged paths");
});

it("keeps private owner context out of public onboarding material", () => {
const preview = buildRepoOnboardingPackPreview({
...POLICY_COMPILER_FIXTURE,
Expand Down