test(integrations): cover whitespace rejection in parseRepoFullName - #9370
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-27 14:43:43 UTC
Review summary Nits — 4 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionPartially addressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Summary
Closes #9318. The whitespace guard the issue describes (
/\s/.test(repoFullName)inparseRepoFullName,src/integrations/project-tracker-adapter.ts:43) is already present in the code, but the adapter's regression tests never exercised a whitespace-containing repo name — only"invalid"and"owner/repo/extra"were covered. This PR closes that gap by adding whitespace-containing cases ("owner/ repo","owner /repo") to the existing invalid-repo-name tests for bothGitHubMilestonesAdapterandGitHubProjectsAdapter, mirroring the pattern already used intest/unit/github-pr-actions.test.ts.Scope
test/unit/project-tracker-adapter.test.tsValidation
npx vitest run test/unit/project-tracker-adapter.test.ts— 54/54 passednpx turbo run build --filter=@loopover/engine— passednpx turbo run build --filter=@loopover/mcp— passednpx turbo run build:tsc build:verify --filter=@loopover/miner— passednpm run test:ci— not completed locally before submission (test-only diff, no src/** changes, low risk)Safety
site/,CNAME, or**/lovable/**Notes
This is a test-coverage-only PR;
test/**is excluded from Codecov'scodecov/patchgate, so there is no coverage obligation beyond the added assertions passing.