fix(rules): recognize .mts/.cts/.mjs/.cjs/.kts/.scala/.groovy in isCodePath - #9373
fix(rules): recognize .mts/.cts/.mjs/.cjs/.kts/.scala/.groovy in isCodePath#9373jeffrey701 wants to merge 1 commit into
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
❌ 3 Tests Failed:
View the top 2 failed test(s) by shortest run time
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
|
Caution 🛑 LoopOver review result - fixes requiredReview updated: 2026-07-27 15:03:02 UTC
Review summary Nits — 4 non-blocking
CI checks failing
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
|
LoopOver is closing this pull request on the maintainer's behalf (CI is failing (validate, validate-tests)). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed. |
What
isCodePathinsrc/rules/advisory.ts— the extension gateannotatablePullRequestFilesuses todecide which changed files
buildCheckRunAnnotationsmay annotate — recognized.ts/.tsx/.js/.jsx,.kt,.java, etc., but was missing the module-variant extensions.mts/.cts/.mjs/.cjsand the JVMextensions
.kts/.scala/.groovy.isCodeFile/SOURCE_FILE_EXTENSION(packages/loopover-engine/src/signals/test-evidence.ts:23)already admit all seven. Because
annotatablePullRequestFilesgates onisCodePathbefore theisCodeFilemissing-test filter runs, a PR touching only those extensions was dropped fromannotatableFilesand never received theMissing test evidenceannotation the parity contractintends.
Change
Add
mts,cts,mjs,cjs,kts,scala,groovyto theisCodePathregex — purely additive.No existing extension is removed or narrowed; the signature, callers, and the rest of
buildCheckRunAnnotations's behavior are unchanged.Validation
test/unit/rules.test.ts(mirrors the existing Vue/Svelte/Astro and C++ parity tests):a source file at each of
.mts/.cts/.mjs/.cjs/.kts/.scala/.groovy, shipped without a test, is nowflagged
Missing test evidence— provingisCodePathadmits it. All fourisCodePathparity testspass.
npx vitest run test/unit/rules.test.tsgreen; the changed line is a single regex literal executedby the passing tests.
Closes #9322