fix(engine): give fleet-run-manifest a dedicated per-repo worktree default - #9374
fix(engine): give fleet-run-manifest a dedicated per-repo worktree default#9374bitfathers94 wants to merge 1 commit into
Conversation
…fault The bare-string repo branch in normalizeRepoList defaulted maxConcurrentWorktrees from DEFAULT_FLEET_RUN_MANIFEST.totalConcurrentWorktrees (a fleet-wide total), while the object-form branch defaulted from a hardcoded literal 1. The two agree only because the fleet-wide total default is also 1 today; changing it would silently move the per-repo default for bare-string entries. Introduce DEFAULT_FLEET_RUN_MANIFEST_REPO_MAX_CONCURRENT_WORKTREES as the single source of truth for the per-repo default and use it in both branches.
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (50.00%) is below the target coverage (99.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #9374 +/- ##
==========================================
- Coverage 75.38% 75.37% -0.01%
==========================================
Files 275 275
Lines 58023 58035 +12
Branches 6181 6181
==========================================
+ Hits 43739 43746 +7
- Misses 14014 14019 +5
Partials 270 270
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Caution 🛑 LoopOver review result - fixes requiredReview updated: 2026-07-27 15:11:05 UTC
Review summary Nits — 3 non-blocking
CI checks failing
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
|
LoopOver is closing this pull request on the maintainer's behalf (CI is failing (codecov/patch, validate, validate-tests)). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed. |
fix(engine): give fleet-run-manifest a dedicated per-repo worktree default
The bare-string repo branch in normalizeRepoList defaulted maxConcurrentWorktrees
from DEFAULT_FLEET_RUN_MANIFEST.totalConcurrentWorktrees (a fleet-wide total),
while the object-form branch defaulted from a hardcoded literal 1. The two agree
only because the fleet-wide total default is also 1 today; changing it would
silently move the per-repo default for bare-string entries.
Introduce DEFAULT_FLEET_RUN_MANIFEST_REPO_MAX_CONCURRENT_WORKTREES as the single
source of truth for the per-repo default and use it in both branches.
Closes #9324
Validation
Verified locally on this branch before opening:
npm run typechecknpx turbo run build:tsc build:verifynpm run test:coverage— patch coverage 100.0% of changed lines