fix(queue): correct maybeApplyManifestPolicyGate's "three"->"two" enforceable-findings comments - #9376
Conversation
…orceable-findings comments policyCodes only has two entries (manifest_linked_issue_required, manifest_missing_tests) since manifest_blocked_path was retired in 329af5a (JSONbored#5304), which removed the dead code but missed updating these two doc comments. resolveConfiguredGateMode in src/rules/advisory.ts confirms two is the current, correct count. Comment-only change; no logic modified.
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
|
Caution 🛑 LoopOver review result - fixes requiredReview updated: 2026-07-27 15:06:48 UTC
Review summary Nits — 3 non-blocking
CI checks failing
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
|
LoopOver is closing this pull request on the maintainer's behalf (CI is failing (validate, validate-tests)). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed. |
Summary
maybeApplyManifestPolicyGate's JSDoc and inline comment both said it pushes "three enforceablepolicy findings", but its actual
policyCodesset — andresolveConfiguredGateModeinsrc/rules/advisory.ts— only has two (manifest_linked_issue_required,manifest_missing_tests).manifest_blocked_pathwas retired by329af5a9(#5304), which removedthe dead code string but missed updating these two doc comments. Both are updated to "two
enforceable policy findings" so the docs match the code.
policyCodesand all logic are unchanged.Validation
grep "three enforceable" src/queue/processors.tsreturns zero occurrences after the fix.changed; no placeholder/stub test added, per the issue's own instruction).
.gittensory.yml.example/config/examples/gittensory.full.ymluntouched (already fixed byfix(config): stop documenting the retired blockedPaths key as a live feature #5304).
npm run typecheckclean.test/unit/selfhost-pg-retention.test.ts— 2 pre-existing failures reproduce identically on aclean sync of
upstream/mainwith only this 2-line comment diff applied (Postgres retentionpruning row-count assertions, e.g.
expected +0 to be 4). Confirmed unrelated to this change —this file/logic is untouched by the diff. A prior PR for this same issue (fix(queue): correct maybeApplyManifestPolicyGate's "three"->"two" enforceable-findings comments #9337) was
auto-closed for this exact same unrelated CI failure.
Closes #9295