fix(engine): give fleet-run-manifest a dedicated per-repo worktree default - #9381
Conversation
…fault The bare-string repo branch in normalizeRepoList defaulted maxConcurrentWorktrees from DEFAULT_FLEET_RUN_MANIFEST.totalConcurrentWorktrees (a fleet-wide total), while the object-form branch defaulted from a hardcoded literal 1. The two agree only because the fleet-wide total default is also 1 today; changing it would silently move the per-repo default for bare-string entries. Introduce DEFAULT_FLEET_RUN_MANIFEST_REPO_MAX_CONCURRENT_WORKTREES as the single source of truth for the per-repo default and use it in both branches.
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9381 +/- ##
==========================================
+ Coverage 89.46% 89.48% +0.01%
==========================================
Files 836 836
Lines 109576 109583 +7
Branches 26094 26097 +3
==========================================
+ Hits 98034 98056 +22
+ Misses 10279 10260 -19
- Partials 1263 1267 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-27 16:03:52 UTC
Review summary Nits — 3 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
The bare-string repo branch in
normalizeRepoListdefaultedmaxConcurrentWorktreesfrom
DEFAULT_FLEET_RUN_MANIFEST.totalConcurrentWorktrees(a fleet-wide total), while theobject-form branch defaulted from a hardcoded literal
1. The two agree only because thefleet-wide total default is also
1today; changing it would silently move the per-repodefault for bare-string entries.
Introduce
DEFAULT_FLEET_RUN_MANIFEST_REPO_MAX_CONCURRENT_WORKTREESas the single source oftruth for the per-repo default and use it in both branches.
Closes #9324
Validation
npm --workspace @loopover/engine run buildnpx vitest run test/unit/fleet-run-manifest-parser.test.ts --coverage— 12 passed, changed lines 100% covered