Skip to content

fix(engine): give fleet-run-manifest a dedicated per-repo worktree default - #9381

Merged
loopover-orb[bot] merged 2 commits into
JSONbored:mainfrom
bitfathers94:fix/issue-9324
Jul 27, 2026
Merged

fix(engine): give fleet-run-manifest a dedicated per-repo worktree default#9381
loopover-orb[bot] merged 2 commits into
JSONbored:mainfrom
bitfathers94:fix/issue-9324

Conversation

@bitfathers94

Copy link
Copy Markdown
Contributor

The bare-string repo branch in normalizeRepoList defaulted maxConcurrentWorktrees
from DEFAULT_FLEET_RUN_MANIFEST.totalConcurrentWorktrees (a fleet-wide total), while the
object-form branch defaulted from a hardcoded literal 1. The two agree only because the
fleet-wide total default is also 1 today; changing it would silently move the per-repo
default for bare-string entries.

Introduce DEFAULT_FLEET_RUN_MANIFEST_REPO_MAX_CONCURRENT_WORKTREES as the single source of
truth for the per-repo default and use it in both branches.

Closes #9324

Validation

  • npm --workspace @loopover/engine run build
  • npx vitest run test/unit/fleet-run-manifest-parser.test.ts --coverage — 12 passed, changed lines 100% covered

…fault

The bare-string repo branch in normalizeRepoList defaulted maxConcurrentWorktrees
from DEFAULT_FLEET_RUN_MANIFEST.totalConcurrentWorktrees (a fleet-wide total),
while the object-form branch defaulted from a hardcoded literal 1. The two agree
only because the fleet-wide total default is also 1 today; changing it would
silently move the per-repo default for bare-string entries.

Introduce DEFAULT_FLEET_RUN_MANIFEST_REPO_MAX_CONCURRENT_WORKTREES as the single
source of truth for the per-repo default and use it in both branches.
@bitfathers94
bitfathers94 requested a review from JSONbored as a code owner July 27, 2026 15:16
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.48%. Comparing base (ffdea0c) to head (cfe5af7).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9381      +/-   ##
==========================================
+ Coverage   89.46%   89.48%   +0.01%     
==========================================
  Files         836      836              
  Lines      109576   109583       +7     
  Branches    26094    26097       +3     
==========================================
+ Hits        98034    98056      +22     
+ Misses      10279    10260      -19     
- Partials     1263     1267       +4     
Flag Coverage Δ
backend 95.21% <100.00%> (-0.01%) ⬇️
engine 65.71% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/loopover-engine/src/fleet-run-manifest.ts 86.29% <100.00%> (+10.37%) ⬆️
packages/loopover-engine/src/index.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 27, 2026
@loopover-orb

loopover-orb Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Tip

✅ LoopOver review result - approve/merge recommended

Review updated: 2026-07-27 16:03:52 UTC

4 files · 1 AI reviewer · no blockers · readiness 98/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
Straightforward fix that introduces a single dedicated `DEFAULT_FLEET_RUN_MANIFEST_REPO_MAX_CONCURRENT_WORKTREES` constant and uses it in both the bare-string and object-form branches of `normalizeRepoList`, replacing a coupling to `DEFAULT_FLEET_RUN_MANIFEST.totalConcurrentWorktrees` and a hardcoded literal `1`. The change is correct and well-tested — new tests exercise both branches with a non-default `totalConcurrentWorktrees` to prove the per-repo default no longer inherits the fleet-wide total. The `index.ts` long-file flag is pre-existing barrel growth, not something this diff meaningfully worsens (it adds one export line).

Nits — 3 non-blocking
  • The `long-file` smell on packages/loopover-engine/src/index.ts is pre-existing barrel bloat (this diff only adds one export line to it), so it's not something to hold this PR to.
  • codecov/patch failed at 77.77%, but given the branch is 11 commits behind default and the added tests visibly cover both the string and object-form default paths, this is likely a coverage-accounting artifact rather than an untested branch — worth confirming after a rebase.
  • Consider rebasing onto the current default branch before merge, since the branch is 11 commits behind and codecov/patch failed without a visible content-level cause in this diff.

Decision drivers

  • ✅ Code review — No blockers (1 reviewer)
  • ✅ Gate result — Passing (No configured blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #9324
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 80 registered-repo PR(s), 54 merged, 0 issue(s).
Contributor context ✅ Confirmed Gittensor contributor bitfathers94; Gittensor profile; 80 PR(s), 0 issue(s).
Improvement ✅ Minor risk: clean · value: minor · LLM: minor
Linked issue satisfaction

Addressed
The diff adds DEFAULT_FLEET_RUN_MANIFEST_REPO_MAX_CONCURRENT_WORKTREES and uses it in both the bare-string and object-form branches as required, and adds tests that set a non-default totalConcurrentWorktrees on the manifest input to prove bare-string and object-form repo entries still fall back to the dedicated per-repo constant rather than the fleet-wide total.

Review context
  • Author: bitfathers94
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: TypeScript
  • Official Gittensor activity: 80 PR(s), 0 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Keep the PR focused and include validation evidence before maintainer review.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoopOver approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit 83a8669 into JSONbored:main Jul 27, 2026
8 checks passed
@github-actions github-actions Bot mentioned this pull request Jul 27, 2026
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

engine: fleet-run-manifest's bare-string repo entries default maxConcurrentWorktrees from the wrong constant

1 participant