fix(integrations): self-heal stale tokens in project-tracker adapters - #9391
Conversation
GitHubMilestonesAdapter and GitHubProjectsAdapter minted installation tokens directly without withInstallationTokenRetry, so a stale cached token on any of the four real methods failed straight through instead of self-healing like every src/github write helper (JSONbored#6191). Wrap all four token+Octokit sequences. Closes JSONbored#9316
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9391 +/- ##
===========================================
- Coverage 89.46% 75.43% -14.04%
===========================================
Files 836 276 -560
Lines 109609 58159 -51450
Branches 26103 6217 -19886
===========================================
- Hits 98067 43875 -54192
- Misses 10279 14014 +3735
+ Partials 1263 270 -993
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-27 16:04:03 UTC
Review summary Nits — 3 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Summary
GitHubMilestonesAdapterandGitHubProjectsAdapterinsrc/integrations/project-tracker-adapter.tsminted installation tokens directly and passed them to Octokit with nowithInstallationTokenRetrywrapper — unlike every GitHub-write helper insrc/github/(#6191). A stale cached token on any of the four real methods failed straight through (list → empty via caller catch; attach → hard fail) instead of self-healing.Wraps
listOpenMilestones,attachToMilestone,listOpenProjects, andattachToProjecttoken+Octokit sequences inwithInstallationTokenRetry.Test plan
test/unit/project-tracker-adapter.test.ts: 401-then-success retry for all four methods (2 token mints, 2 attempts each)Closes #9316