fix(review): widen fix-handoff code-span delimiter for backtick paths(#9289) - #9407
Conversation
…JSONbored#9289) markdownPathCodeText backslash-escaped backticks before callers wrapped the location in a single-backtick span, but CommonMark/GFM code spans do not honor backslash escapes. Mirror markdownPathCode: longest backtick run + 1 delimiter (with padding spaces), and consume that span directly at both call sites. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-27 16:36:20 UTC
Review summary Nits — 4 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9407 +/- ##
==========================================
+ Coverage 75.46% 75.47% +0.01%
==========================================
Files 275 276 +1
Lines 58030 58060 +30
Branches 6199 6212 +13
==========================================
+ Hits 43790 43820 +30
Misses 13970 13970
Partials 270 270
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Summary
markdownPathCodeTextto use a longest-backtick-run-plus-one delimiter (with surrounding spaces), matchingmarkdownPathCodeinunified-comment-bridge.ts, instead of backslash-escaping backticks.buildFixHandoffBlockandfixHandoffAggregateItemto consume the function's own delimiter-wrapped output (no hardcoded single-backtick re-wrap).|/<>/\escaping; only backtick handling changes.Why prior linked PRs failed
Prior attempts (#9339, #9347, #9353) had correct #9289 code and a passing gate review (no blockers). They were auto-closed solely because CI
validate/validate-testsfailed on unrelated pre-existing flakes intest/unit/selfhost-pg-retention.test.ts(not on the fix-handoff change). Those retention failures are fixed on currentmain(#9285/ follow-ups); this branch is based on that tip.Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Closes #123) — a linked open issue is required for every contributor PR.Validation
git diff --checknpx vitest run test/unit/fix-handoff-render.test.ts test/unit/fix-handoff-collapsible.test.ts— 36 passednpx vitest run test/unit/queue-4.test.ts -t "Fix handoff|fix-handoff|handoff"— 1 passednpx vitest run test/unit/selfhost-pg-retention.test.ts— 7 passed (the failure mode that closed prior PRs)npm run test:ci(full gate; run before push)If any required check was skipped, explain why:
Implementation + targeted regressions green; the historical CI killer (
selfhost-pg-retention) also green on this tip. Fulltest:cileft for the opener.Safety
site/,CNAME,**/lovable/**, or rootCHANGELOG.md.UI Evidence
N/A — markdown rendering in review comments only; no product UI surface.
Notes for reviewers / gate
src/review/unified-comment-bridge.tsmarkdownPathCode/markdownChangedFilePath.unified-comment-bridge.ts(issue forbids it).markdownPathCode.