fix(openapi): document /v1/opportunities/find + /v1/issue-rag/retrieve (#9310) - #9448
Closed
andriypolanski wants to merge 5 commits into
Closed
Conversation
JSONbored#9310) Both discovery routes were live (and MCP-backed) but absent from OpenAPI. Add request/response schemas mirroring the MCP tool shapes, register the POST paths, regenerate openapi.json, and add regression assertions. Replaces conflict-closed JSONbored#9423 on current main. Co-authored-by: Cursor <cursoragent@cursor.com>
Resolve the openapi.json conflict by regenerating from the merged schemas/spec sources so JSONbored#9310 opportunities/issue-rag paths and main coexist. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
This repository reviews pull requests one-shot: the PR must be correct as originally opened. Pushing an additional commit closes it automatically instead of restarting review — open a fresh pull request with every fix included. |
Contributor
|
Important 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏳ LoopOver is waiting…LoopOver has seen this pull request and is waiting on CI checks to finish before reviewing it. This comment will update once the review runs. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed · 🟨 Waiting |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9448 +/- ##
==========================================
+ Coverage 75.51% 75.69% +0.18%
==========================================
Files 275 277 +2
Lines 58032 58470 +438
Branches 6209 6216 +7
==========================================
+ Hits 43820 44257 +437
Misses 13942 13942
- Partials 270 271 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9310
Summary
FindOpportunitiesRequest/FindOpportunitiesResponseandIssueRagRetrieveRequest/IssueRagRetrieveResponseschemas mirroring the MCP tool Zod shapes (reusing the sameMAX_FIND_OPPORTUNITIES_*/MAX_ISSUE_RAG_*/PREFLIGHT_LIMITSconstants).src/openapi/spec.ts(same registration pattern as#6611/gate-config/effective).apps/loopover-ui/public/openapi.json.openapi.test.tswith path/schema presence + field regression guards (aiPolicyAllowed,retrievedPathCount).Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Closes #123) — a linked open issue is required for every contributor PR.Validation
git diff --checknpm run ui:openapi+npm run ui:openapi:checknpx vitest run test/unit/openapi.test.ts— 5 passednpm run test:ci(full gate; run before push)If any required check was skipped, explain why:
OpenAPI documentation + regeneration + targeted contract test complete. Full
test:cileft for the opener.Safety
site/,CNAME,**/lovable/**, or rootCHANGELOG.md.UI Evidence
N/A — OpenAPI contract / generated
openapi.jsononly; no product UI change.Notes for reviewers / gate