Skip to content

fix(ci): bump the cache-key salt so #9596's widened path list actually takes effect #9597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jul 28, 2026
+8 −1
Merged

fix(ci): bump the cache-key salt so #9596's widened path list actually takes effect #9597

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/actions/setup-workspace/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,14 @@ runs:
# Globbing `apps/*` + `packages/*` (the workspace globs from package.json) makes the cache follow
# npm's layout automatically instead of re-breaking on the next hoist change. review-enrichment
# and control-plane are NOT workspaces -- they have their own installs and their own cache steps.
key: npm-${{ (github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork == true) && 'fork' || 'trusted' }}-${{ hashFiles('.nvmrc') }}-${{ hashFiles('package.json', 'apps/*/package.json', 'packages/*/package.json', 'package-lock.json') }}
# `v2` is a manual cache-generation salt, and bumping it is REQUIRED whenever the `path` list
# above changes. Widening `path` alone does not invalidate anything: the key is computed from the
# manifests only, so an unchanged lockfile keeps HITTING the pre-existing entry, which was
# archived from the narrow path list and therefore still restores no
# `apps/loopover-miner-ui/node_modules` -- and a hit skips `npm ci`, so the tree stays incomplete
# exactly as before. (#9596 widened the list without this bump and did not take effect.) Bumping
# the salt forces one clean miss so a complete tree gets archived under the current list.
key: npm-v2-${{ (github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork == true) && 'fork' || 'trusted' }}-${{ hashFiles('.nvmrc') }}-${{ hashFiles('package.json', 'apps/*/package.json', 'packages/*/package.json', 'package-lock.json') }}

- name: Install dependencies (retry on transient failures)
if: ${{ steps.node-modules-cache.outputs.cache-hit != 'true' }}
Expand Down
Loading