Skip to content

fix(ci): update the setup-workspace cache assertions to the widened path list #9603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jul 28, 2026
+12 −1
Merged

fix(ci): update the setup-workspace cache assertions to the widened path list #9603

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion test/unit/ci-composite-setup-workspace.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,15 @@ describe("setup-workspace composite action", () => {
expect(restore.uses).toContain("actions/cache/restore@");
const restoreWith = record(restore.with, "restore.with");
expect(String(restoreWith.path)).toContain("node_modules");
expect(String(restoreWith.path)).toContain("apps/loopover-ui/node_modules");
// #9596: the path list must cover EVERY workspace, via the same globs package.json declares -- npm
// decides per dependency whether it hoists to the root or nests under a workspace, and pinning one app
// by name is what let a cache hit restore a tree with no apps/loopover-miner-ui/node_modules at all.
expect(String(restoreWith.path)).toContain("apps/*/node_modules");
expect(String(restoreWith.path)).toContain("packages/*/node_modules");
// #9597: the path list and the KEY must move together. Widening the paths alone changes nothing --
// an unchanged lockfile keeps hitting the entry archived under the old list -- so the generation salt
// is asserted here, beside the paths, to keep the two from drifting apart again.
expect(String(restoreWith.key)).toContain("npm-v2-");
expect(String(restoreWith.key)).toContain("hashFiles('package.json', 'apps/*/package.json', 'packages/*/package.json', 'package-lock.json')");
expect(String(restoreWith.key)).toContain("package.json");
expect(String(restoreWith.key)).toContain("apps/*/package.json");
Expand All @@ -74,6 +82,9 @@ describe("setup-workspace composite action", () => {
expect(save.uses).toContain("actions/cache/save@");
const saveWith = record(save.with, "save.with");
expect(saveWith.key).toBe("${{ steps.node-modules-cache.outputs.cache-primary-key }}");
// The SAVE list is the one that decides what a future run can restore, so a narrowing here would be
// invisible until some later job failed on a missing workspace -- assert it matches the restore list.
expect(String(saveWith.path)).toBe(String(restoreWith.path));

// Save must come after install (a broken/partial node_modules from a failed install step is never reached).
const stepNames = steps.map((s) => s.name);
Expand Down