Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions apps/loopover-ui/public/openapi.json
Original file line number Diff line number Diff line change
Expand Up @@ -26291,14 +26291,20 @@
}
],
"responses": {
"200": {
"description": "Transfer requested"
"202": {
"description": "Transfer initiation accepted (pending acceptance)"
},
"400": {
"description": "Malformed request"
},
"401": {
"description": "Missing or invalid token"
},
"409": {
"description": "Transfer gate rejected the request; GitHub was not touched"
},
"502": {
"description": "Transfer attempt failed downstream"
}
}
}
Expand Down
8 changes: 7 additions & 1 deletion src/openapi/internal-and-public-route-specs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,13 @@ const MISC_ROUTES: SpecEntry[] = [
tags: ["Loop"],
summary: "Request an APR transfer for a rented loop",
auth: "token",
responses: { 200: { description: "Transfer requested" }, 400: { description: "Malformed request" }, 401: { description: "Missing or invalid token" } },
responses: {
202: { description: "Transfer initiation accepted (pending acceptance)" },
400: { description: "Malformed request" },
401: { description: "Missing or invalid token" },
409: { description: "Transfer gate rejected the request; GitHub was not touched" },
502: { description: "Transfer attempt failed downstream" },
},
},
{
method: "post",
Expand Down
4 changes: 4 additions & 0 deletions test/unit/openapi.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,10 @@ describe("OpenAPI contract", () => {
const aprTransfer = spec.paths["/v1/loop/request-apr-transfer"]?.post;
expect(aprTransfer?.operationId).toBe("requestAprTransfer");
expect(aprTransfer?.requestBody).toBeUndefined();
// #9711: the declared statuses must match the handler's real exits (400/409/502/202) — never the 200 it
// could never return. A spec claiming 200 for a route that only ever answers 202 misleads every generated
// client.
expect(Object.keys(aprTransfer?.responses ?? {}).sort()).toEqual(["202", "400", "401", "409", "502"]);
});

// #9308: the eight /v1/lint/* + /v1/validate/focus-manifest advisory-check routes are each backed by an MCP
Expand Down
Loading