fix(test): restore main by catching #9813's expectations up to its own change - #9829
Merged
Merged
Conversation
…n change main's CI has been red since #9813 (gate.ignoredCheckRuns) merged -- the last four ci.yml runs on main all failed, and every branch cut from or merged with main inherits it. #9804 went red on these tests with no changes of its own anywhere near them. #9813's implementation is correct; only the expectations were left behind: * fetchLiveCiAggregate / fetchLiveCiAggregatePreferGraphQl gained an eighth parameter (ignoredCheckRuns) while four toHaveBeenCalledWith assertions still passed seven; * the durable cache key gained an `|ign:` segment, while queue.test.ts's durable-cache regression still expected `|adv:` alone; * the whole ignoredCheckRuns block (19 lines) was added to .loopover.yml.example but not to config/examples/loopover.full.yml, which config-templates.test.ts requires byte-identical from `# WHERE IT LIVES` onward. No production behaviour changes. This matters beyond a red build: the gate auto-CLOSES a contributor PR on red CI, so a contributor who opened a PR after #9813 landed would be closed for a defect that is not theirs and that they cannot fix -- the same harm #9798 and #9801 describe, except this one does not self-correct. Closes #9828
Contributor
|
Important 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏳ LoopOver is waiting…LoopOver has seen this pull request and is waiting on CI checks to finish before reviewing it. This comment will update once the review runs. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed · 🟨 Waiting |
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
This was referenced Jul 29, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9829 +/- ##
===========================================
+ Coverage 79.03% 90.76% +11.73%
===========================================
Files 280 915 +635
Lines 58366 112700 +54334
Branches 6697 27077 +20380
===========================================
+ Hits 46128 102294 +56166
+ Misses 11955 9314 -2641
- Partials 283 1092 +809
Flags with carried forward coverage won't be shown. Click here to find out more. |
This was referenced Jul 29, 2026
Closed
loopover-orb Bot
pushed a commit
that referenced
this pull request
Jul 29, 2026
…9837) contract:api-schemas:check fails on main: #9813 added ignoredCheckRuns to RepositorySettingsSchema in src/ without committing the regenerated contract copy. Fourth piece of that PR's fallout, after the three #9829 fixed. @loopover/contract is what MCP and miner consume, and api-schemas.ts is what an external client validates a settings write against -- so a client built on the published contract silently strips ignoredCheckRuns: accepted by the server, absent from the schema, configuration that appears to save and then does nothing. Generated output, not hand-edited: `npm run contract:api-schemas`. Closes #9836
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9828
main is red
The last four
ci.ymlruns onmainarefailure, since #9813 (gate.ignoredCheckRuns) merged. Every branch cut from or merged withmaininherits it — #9804 went red on exactly these tests with no changes of its own anywhere near them, which is how I found it.#9813's implementation is correct. Only its expectations were left behind:
agent-approval-queue.test.ts, 1 ×queue.test.tsfetchLiveCiAggregate/fetchLiveCiAggregatePreferGraphQlgained an eighth parameter (ignoredCheckRuns); thetoHaveBeenCalledWithassertions still pass sevenqueue.test.tsdurable-cache regression…|adv:…|ign:…; the assertion still expects|adv:aloneconfig-templates.test.tsignoredCheckRunsblock was added to.loopover.yml.examplebut notconfig/examples/loopover.full.yml, which must match byte-for-byte from# WHERE IT LIVESonwardNo production behaviour changes — every edit is to a test expectation or the unsynced example template.
loopover.full.yml's tail is copied verbatim from.loopover.yml.examplerather than hand-retyped, so the two are byte-identical by construction.Why this is worth its own PR rather than a fix inside another
Per the gate's disposition matrix, red CI auto-CLOSES a contributor PR. A contributor who opened a PR after #9813 landed gets closed for a defect that is not theirs and that they cannot fix — the same class of harm #9798 and #9801 describe, except this one does not self-correct. That deserves the shortest possible path to green on
main.Validation
490 tests pass across
queue,agent-approval-queue,config-templates,gate-check-policyandpr-detail-durable-cache.tsc --noEmit,selfhost:config-lint,docs:drift-check,import-specifiers:checkall clean.Verified the failures reproduce on unmodified
origin/mainbefore fixing, so this is confirmed as the cause rather than an interaction with my other branches.Follow-up noted in the issue
config-templates.test.tscatches template divergence only after merge. The byte-identical-from-a-marker relationship is really a generation relationship expressed as an assertion —loopover.full.yml's tail could be generated from.loopover.yml.examplevia a:write/:checkpair likereplay-runner-image-manifestorgen-contract-api-schemas, so the two could not drift at all. Out of scope here; the priority is gettingmaingreen.