fix(ui-kit): ratchet-clean src/components (16/19 files, 38/43 violations)#8177
Conversation
…ons) Converts each no-restricted-syntax violation to its named token per the eslint message: text-[9-13px] one-offs onto mg-type-micro/label/caption/ data/data-sm (dropping the now-redundant font-mono/uppercase/tracking utilities where the token already supplies them), off-scale px-5/pb-14/ mb-5 spacing snapped to the nearest --mg-space-*-backed step, the ActionBar/SegmentedToggle/PrimaryLinksRail hand-rolled shells wrapped in <Panel flush bodyClassName=...> (the same recipe JSONbored#8083 already proved for connected icon-bar shells), and PrimaryLinksRail's icon segments moved onto <ExternalLink bare> (a new opt-in prop that skips the glyph/underline for icon-only composition -- everything else keeps ExternalLink's default rendering). RATCHETED_DIRS gains "src/components/**/*.{ts,tsx}" with a 3-file `ignores`: entity-hero.tsx and page-hero.tsx each still carry a hero <h1>/KPI-value size (text-[2.5rem]/[1.75rem]) with no mg-type-* or Tailwind-native equivalent past caption-lg (13px) -- no display/heading tier is authored yet, so forcing these onto mg-type-caption would shrink the page hero. section-anchor.tsx's scroll-mt-32 is the same sticky-header scroll-offset compensation JSONbored#7810 already left unconverted elsewhere in the codebase, not a spacing-scale value. Ratcheting around these 3 (rather than leaving all of src/components/** un-ratcheted over them) still fails CI on any new drift in the other 16 files -- confirmed by introducing then reverting a throwaway violation in accent-band.tsx (errors, not warnings) before/after this change. npx eslint src/components: 43 warnings -> 5 (0 errors either way). npx tsc --noEmit / prettier --check / vitest run (98 tests): all clean. dist rebuilt via npm run build (committed per this package's own .gitignore exception for the runtime bundle). Closes JSONbored#8172
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8177 +/- ##
=======================================
Coverage 97.82% 97.82%
=======================================
Files 415 415
Lines 28893 28893
Branches 10850 10850
=======================================
Hits 28265 28265
Misses 141 141
Partials 487 487 🚀 New features to boost your workflow:
|
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-25 23:43:05 UTC
Review summary Nits — 6 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionPartially addressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. Visual preview
Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy · Diff highlights exactly what changed. Scroll preview
A short scroll-through clip (desktop) — click either thumbnail to open the full animation. Evidence for scroll-linked behavior a single screenshot can't show. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|



fix(ui-kit): ratchet-clean src/components (16/19 files, 38/43 violations)
Converts each no-restricted-syntax violation to its named token per the
eslint message: text-[9-13px] one-offs onto mg-type-micro/label/caption/
data/data-sm (dropping the now-redundant font-mono/uppercase/tracking
utilities where the token already supplies them), off-scale px-5/pb-14/
mb-5 spacing snapped to the nearest --mg-space-*-backed step, the
ActionBar/SegmentedToggle/PrimaryLinksRail hand-rolled shells wrapped in
(the same recipe #8083 already proved for
connected icon-bar shells), and PrimaryLinksRail's icon segments moved
onto (a new opt-in prop that skips the glyph/underline
for icon-only composition -- everything else keeps ExternalLink's default
rendering).
RATCHETED_DIRS gains "src/components/**/*.{ts,tsx}" with a 3-file
ignores: entity-hero.tsx and page-hero.tsx each still carry a hero/KPI-value size (text-[2.5rem]/[1.75rem]) with no mg-type-* or Tailwind-native equivalent past caption-lg (13px) -- no display/heading tier is authored yet, so forcing these onto mg-type-caption would shrink the page hero. section-anchor.tsx's scroll-mt-32 is the same sticky-header scroll-offset compensation #7810 already left unconverted elsewhere in the codebase, not a spacing-scale value. Ratcheting around these 3 (rather than leaving all of src/components/** un-ratcheted over them) still fails CI on any new drift in the other 16 files -- confirmed by introducing then reverting a throwaway violation in accent-band.tsx (errors, not warnings) before/after this change.
npx eslint src/components: 43 warnings -> 5 (0 errors either way).
npx tsc --noEmit / prettier --check / vitest run (98 tests): all clean.
dist rebuilt via npm run build (committed per this package's own
.gitignore exception for the runtime bundle).
Closes #8172