fix(ui): swap raw Bone & Ink one-off values for design tokens in batch 5/5#8183
Conversation
…h 5/5 Converts the remaining no-restricted-syntax violations (arbitrary text-[Npx] sizes, one raw spacing step, a hand-rolled card shell, and a raw <a target=_blank>) across 12 of the 13 files in this batch to the matching primitive/token, no visual/behavioral change intended: - Plain-sans micro text (9-11.5px, no font-mono) snaps to mg-type-caption (12px) -- the smallest sans step on the scale; there's no sub-12px sans token, so this is a sub-2px size normalization, same tolerance already established for the 12/13px caption band itself. - subnets-highlights.tsx's one 15px value gets an exact-match inline style against the already-defined-but-unconsumed --mg-type-body-lg var, rather than approximating. - take-management-modal.tsx's direction-toggle segmented control now wraps in <Panel>, with the flex layout moved to bodyClassName so the buttons stay direct flex children instead of nesting under Panel's own padding wrapper. - wallet-connect.tsx's wallet-picker link now uses <ExternalLink> from @jsonbored/ui-kit instead of a hand-rolled <a target=_blank> + safeExternalUrl call. validators-compare-drawer.tsx's 3 sticky-cell z-[1]/z-[2] values are deliberately left as-is -- CONTRIBUTING.md documents this exact file's sticky corner cell as the one standing exception to the --mg-z-* scale (local table stacking context, not a global layer), and its sibling subnets-compare-drawer.tsx carries the identical untouched pattern. Converting it would fight the documented intent for no real benefit. Closes JSONbored#8171.
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8183 +/- ##
=======================================
Coverage 97.82% 97.82%
=======================================
Files 415 415
Lines 28893 28893
Branches 10850 10850
=======================================
Hits 28265 28265
Misses 141 141
Partials 487 487 🚀 New features to boost your workflow:
|
|
Warning ⏸️ LoopOver review result - manual review recommendedReview updated: 2026-07-26 00:38:10 UTC
Review summary Nits — 7 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionPartially addressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. Visual preview
Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy · Diff highlights exactly what changed. Scroll preview
A short scroll-through clip (desktop) — click either thumbnail to open the full animation. Evidence for scroll-linked behavior a single screenshot can't show. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|




fix(ui): swap raw Bone & Ink one-off values for design tokens in batch 5/5
Converts the remaining no-restricted-syntax violations (arbitrary
text-[Npx] sizes, one raw spacing step, a hand-rolled card shell, and a
raw ) across 12 of the 13 files in this batch to the
matching primitive/token, no visual/behavioral change intended:
(12px) -- the smallest sans step on the scale; there's no sub-12px sans
token, so this is a sub-2px size normalization, same tolerance already
established for the 12/13px caption band itself.
style against the already-defined-but-unconsumed --mg-type-body-lg
var, rather than approximating.
wraps in , with the flex layout moved to bodyClassName so the
buttons stay direct flex children instead of nesting under Panel's own
padding wrapper.
@jsonbored/ui-kit instead of a hand-rolled +
safeExternalUrl call.
validators-compare-drawer.tsx's 3 sticky-cell z-[1]/z-[2] values are
deliberately left as-is -- CONTRIBUTING.md documents this exact file's
sticky corner cell as the one standing exception to the --mg-z-* scale
(local table stacking context, not a global layer), and its sibling
subnets-compare-drawer.tsx carries the identical untouched pattern.
Converting it would fight the documented intent for no real benefit.
Closes #8171.
Screenshots
before
after
before
after
before
after
before
after
before
after
before
after