refactor(fleet): use shared release helper shim#29
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dfff0d0bad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| except ModuleNotFoundError as exc: | ||
| raise SystemExit( | ||
| f"Release commit {release_commit} for {version} is not reachable from HEAD." | ||
| "aio_fleet.release is required. Run from the standard workspace with " | ||
| "../aio-fleet present, or let the reusable aio-fleet workflows check " | ||
| "out .aio-fleet before invoking this shim." |
There was a problem hiding this comment.
The new shim hard-fails when aio_fleet is not checked out at .aio-fleet/src or ../aio-fleet/src, so a normal clone of this repo can no longer run python scripts/release.py ... (it exits with code 1 and the ModuleNotFoundError message). This is a regression from the previous self-contained helper and breaks local release automation/tests outside the reusable workflow context; at minimum, the shim needs a fallback path (vendored logic or installable dependency) so repo-local release commands continue to work.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e56841296d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| capture_output=True, | ||
| ) | ||
|
|
||
| assert result.returncode == 0, result.stderr # nosec B101 |
There was a problem hiding this comment.
This assertion hard-requires scripts/release.py to exit successfully, but the new shim only works when .aio-fleet/src or ../aio-fleet/src is present; in a standard standalone clone, it exits with ModuleNotFoundError and this test fails, turning the unit suite red for contributors without the fleet checkout. Fresh evidence: running python3 -m pytest -q tests/unit/test_release_shim.py in this repo fails at this assertion with that exact error.
Useful? React with 👍 / 👎.
1 participant
Summary
What changed
scripts/release.pynow delegates toaio_fleet.release.aio-fleetfor release helper usageWhy
Validation
python3 scripts/release.py next-versionpython -m aio_fleet validate --allpython -m aio_fleet sync-workflows --dry-run --ref 3b8613bf305a8bbebfe9f61636db935c303fe2cdpython -m aio_fleet sync-boilerplate --dry-runpython -m aio_fleet debt-report --catalog-path /Users/shadowbook/.codex/worktrees/7c71/awesome-unraid --format textpython -m aio_fleet trunk-auditgit diff --checkNotes