Some update ideas for the code-style#4
Open
felipenmoura wants to merge 3 commits intoJSRocksHQ:masterfrom
Open
Some update ideas for the code-style#4felipenmoura wants to merge 3 commits intoJSRocksHQ:masterfrom
felipenmoura wants to merge 3 commits intoJSRocksHQ:masterfrom
Conversation
These are just some ideas.
Member
There was a problem hiding this comment.
no space inside function call's parentheses
Author
There was a problem hiding this comment.
ok, fixing it...but notice that it was already there :p
it wasn't me who added those spaces.
Member
There was a problem hiding this comment.
heheh no problem. We would need to update it sooner or later.
Member
|
Nice work, I took a quick look and added a few review comments above. |
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ + ] Throw, try and catch
[ + ] Strict mode
[ * ] Observations to some itens
[ + ] Some examples