Suppress paragraph space-before at page tops - #431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
h1–h6w:pageBreakBefore, section starts, and same-page spacing, plus direct hard-break/heading/non-paragraph probesWhy this belongs in the paginator
The converter must preserve the authored
w:spacing/@w:before; whether Word paints it depends on where pagination places the paragraph. The paginator now records paragraph semantics during measurement and applies one page-placement rule to keep-with-next chain sizing, ordinary body budgeting, fresh-page fallback, and the cloned block that is rendered.The rule is section-aware: page 1 of a document or section retains its authored space-before, while the first Word paragraph on a later page suppresses it. Tables and other block margins are not treated as paragraph spacing.
Verification
npm run typechecknpm run test:package-boundary(163 runtime/license files)legal-contractvisual-parity run: 3/3 pages, no conversion errorsThe visual rerun used the contracted LibreOffice 25.8.7.3 and Chromium 143. Poppler was 25.03 rather than the committed ratchet's 24.02, so the full-corpus ratchet was intentionally not rewritten; the recorded comparison is before/after in the same environment.
Fixes #428