True Black Theme#171
Draft
DXCanas wants to merge 18 commits intoJaapvanEkris:0.9.7-(under-construction)from
Draft
True Black Theme#171DXCanas wants to merge 18 commits intoJaapvanEkris:0.9.7-(under-construction)from
DXCanas wants to merge 18 commits intoJaapvanEkris:0.9.7-(under-construction)from
Conversation
Owner
|
Testing challenge accepted :) |
Author
|
During live testing, I think I ran into something completely unrelated regarind fit file writing in the |
Owner
Thanks, will pick it up this weekend. As this hasn't changed, I assume it is also in the production branch. |
Owner
Why does this happen? I think there should be a stop-command in between? What kind of session did you use? |
Author
As far as I know, I was just picking up the handle and yanking 🤷. Really, this came up while I was calibrating things for the the thread over in #140 If I recall, the order went:
So it was a secondary thing I caught while testing the new UI and calibrating. |
DXCanas
force-pushed
the
true-black-theme
branch
2 times, most recently
from
51e4804 to
f2d04df
Compare
…onent Extracted toolbar functionality from PerformanceDashboard into new DashboardToolbar component. Removed 'actions' from default dashboard metrics. Updated layout to use flexbox with separate toolbar and metrics grid sections.
… in localStorage. Remove deprecated DashboardActions component and migrate saved metrics Deleted DashboardActions.js component as functionality has been moved to DashboardToolbar.
Replaced dynamic inline style injection with CSS class-based approach for grid row configuration. Changed metrics container from div to semantic section element. Updated grid layout to use explicit grid-template-rows and added .rows-3 modifier class for 12-tile configuration.
…vements Reorganized CSS properties for better readability and consistency. Simplified button styles by removing redundant properties and using flex instead of inline-flex. Changed fullscreen/windowed icon containers from div with IDs to span with classes. Consolidated media query icon display rules into single-line declarations.
Added explicit grid-template-areas to PerformanceDashboard for clearer layout structure. Added min-height: 0 to metrics-grid and metric-tile to prevent grid blowout issues.
…rt legend. More reliable - Avoids Chart.js legend bugs on iOS and autoscaling issues Better for responsive design - HTML text naturally inherits the fluid typography Added host flex container styles and title styling at 80% font size with center alignment.
DXCanas
force-pushed
the
true-black-theme
branch
2 times, most recently
from
70101b5 to
169b8cf
Compare
Author
Owner
|
What is the status of this PR? Can I start testing it? |
Author
|
I was going to leave in draft until #170 was finalized so I could do a final rebase/merge |
…font size slightly.
All chart.js rendered labels already gone. This removes the standard markup text as well.
DXCanas
force-pushed
the
true-black-theme
branch
2 times, most recently
from
ffcd34e to
43752d0
Compare
For start, mostly. To prevent confusion.
Including new border definition, for division in true-black mode.
Theme preference is persisted to localStorage and applied via data-theme attribute on document root element.
DXCanas
force-pushed
the
true-black-theme
branch
from
43752d0 to
2c31f91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For those of us who do not have a tiny screen to attach to our Pi's, and want to preserve the battery of our smartphones!
Sets the stage for more themes, in case someone ever sets up… idk, MIP? E-Ink? 🤷
Currently depends on #170, though can be refactored to remove that dependency.
Using CSS themes, tucking setting away under
Experimentaluntil it's a little more battle-tested.Opted for borders over full background for maximum power savings.
Testing TBD