Skip to content

Fix NullPointerException in CoordinateGrabber on LAN servers #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
O0rphan wants to merge 1 commit into
base: 1.20.1
Choose a base branch
from
Open

Fix NullPointerException in CoordinateGrabber on LAN servers #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions jackfredlib-gps/src/client/java/red/jackf/jackfredlib/client/impl/gps/CoordinateGrabber.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,18 @@ public static Optional<Coordinate> get() {
));
// LAN server
} else if (serverData.isLan()) {
String motd = serverData.motd.getString();
// LAN-FIX VERSION: motd can be null sometimes, fallback to server name or empty string
String motd = serverData.motd != null ? serverData.motd.getString() :
(serverData.name != null ? serverData.name : "LAN");
// Extract world name from MOTD format "PlayerName - WorldName"
// Use singleplayer prefix so LAN guests share the same Memory Bank as host
String worldName = motd;
int separatorIndex = motd.indexOf(" - ");
if (separatorIndex != -1 && separatorIndex + 3 < motd.length()) {
worldName = motd.substring(separatorIndex + 3);
}
return Optional.of(new Coordinate.Lan(
"lan/" + Sanitizer.sanitize(motd),
"singleplayer/" + Sanitizer.sanitize(worldName),
"LAN: " + motd
));
// Multiplayer
Expand Down