Fix didChange out-of-range crash in ollama_lsp#10
Open
cmtonkinson wants to merge 1 commit intoJacob411:mainfrom
Open
Fix didChange out-of-range crash in ollama_lsp#10cmtonkinson wants to merge 1 commit intoJacob411:mainfrom
cmtonkinson wants to merge 1 commit intoJacob411:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a crash in
python/ollama_lsp.pywhen handlingtextDocument/didChangeevents with ranges that are missing or out of bounds.Problem
on_changeassumed:change.rangeis always presentchange.range.start.lineis always withindocument.lineschange.range.start.characteris always within the current lineIn real edit/delete flows, those assumptions can be violated, causing exceptions and the Neovim client to exit with code 1.
Changes
In
python/ollama_lsp.py(on_change):change.rangeis missing/Nonestart.line >= len(lines)start.characterbefore slicing the current line (use empty suffix if out of range)This keeps behavior unchanged for valid edits while avoiding crashes on edge-case range payloads.
Validation
python3 -m py_compile python/ollama_lsp.pyollama_lspstays attached after edit operations that previously caused exits