Update import and notification methods in ollama_lsp#9
Open
m-nikolaidis wants to merge 1 commit intoJacob411:mainfrom
Open
Update import and notification methods in ollama_lsp#9m-nikolaidis wants to merge 1 commit intoJacob411:mainfrom
m-nikolaidis wants to merge 1 commit intoJacob411:mainfrom
Conversation
Using this plugin with pygls v2 was throwing the following errors: `from pygls.server import LanguageServer ImportError: cannot import name 'LanguageServer' from 'pygls.server' ` and "send_notification" method not found. This method was removed in the newest version without deprecation warning. Since there is no fixed requirement of pygls version I updated the import and method according to the [documentation](https://pygls.readthedocs.io/en/latest/pygls/howto/migrate-to-v2.html)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using this plugin with pygls v2 was throwing the following errors:
from pygls.server import LanguageServer ImportError: cannot import name 'LanguageServer' from 'pygls.server'and "send_notification" method not found.
This method was removed in the newest version without deprecation warning.
Since there is no fixed requirement of pygls version I updated the import and method according to the documentation.