feat: Add file I/O overloads for BmpTool API#15
Merged
JacobBorden merged 1 commit intodevelopmentfrom Jun 1, 2025
Merged
Conversation
I've integrated file input/output directly into the BmpTool API by adding new overloads for `BmpTool::load` and `BmpTool::save`. Changes include: - Added `BmpTool::load(const std::string& filepath)`: Reads a BMP file from the given path and returns a `BmpTool::Bitmap`. - Added `BmpTool::save(const BmpTool::Bitmap&, const std::string& filepath)`: Saves a `BmpTool::Bitmap` to the specified file path. - I implemented these functions in `src/format/bitmap.cpp`, adapting file reading/writing logic previously found in `main.cpp`. The filepath-based `load` calls the existing span-based `load`. The filepath-based `save` calls the existing span-based `save` using a temporary buffer and then writes the actual data size to the file. - I updated the `main.cpp` example to use these new, more convenient API overloads, removing the local `readFile` and `writeFile` utility functions and associated includes. This change makes the BmpTool library easier for you to use for common file-based operations without requiring you to implement your own file I/O routines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've integrated file input/output directly into the BmpTool API by adding new overloads for
BmpTool::loadandBmpTool::save.Changes include:
BmpTool::load(const std::string& filepath): Reads a BMP file from the given path and returns aBmpTool::Bitmap.BmpTool::save(const BmpTool::Bitmap&, const std::string& filepath): Saves aBmpTool::Bitmapto the specified file path.src/format/bitmap.cpp, adapting file reading/writing logic previously found inmain.cpp. The filepath-basedloadcalls the existing span-basedload. The filepath-basedsavecalls the existing span-basedsaveusing a temporary buffer and then writes the actual data size to the file.main.cppexample to use these new, more convenient API overloads, removing the localreadFileandwriteFileutility functions and associated includes.This change makes the BmpTool library easier for you to use for common file-based operations without requiring you to implement your own file I/O routines.