Refactor gzip decompression flag to explicitly track success state#28
Merged
JacobCoffee merged 2 commits intofix/gzip-compression-injectionfrom Dec 28, 2025
Merged
Conversation
3 tasks
The `is_gzipped` variable was ambiguous - it initially tracked whether the header indicated gzip encoding, but then was repurposed to track whether decompression succeeded. This made the code harder to understand. Renamed to `decompressed` to explicitly indicate it tracks whether we successfully decompressed the body. This makes the logic clearer: - If decompression succeeds and UTF-8 decoding fails, return the decompressed body with no content-encoding header - If decompression fails and UTF-8 decoding fails, return the original body with the original content-encoding header Addresses feedback: #24 (comment) Co-authored-by: JacobCoffee <45884264+JacobCoffee@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Update gzip-compressed responses in toolbar injection
Refactor gzip decompression flag to explicitly track success state
Dec 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
is_gzippedvariable in_inject_toolbar()was ambiguous—it initially tracked whether the Content-Encoding header indicated gzip, then was repurposed to track decompression success.Changes
is_gzippedtodecompressedwith explicit success trackinggzip.decompress()succeeds, not based on header presenceis_gzipped = False) with explicit initialization patternBefore:
After:
The flag now unambiguously indicates whether we hold decompressed data, making the subsequent error handling logic clearer.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.