Fix panic when IO error for some cpu features#558
Open
Camerooooon wants to merge 5 commits intoJakeRoggenbuck:mainfrom
Open
Fix panic when IO error for some cpu features#558Camerooooon wants to merge 5 commits intoJakeRoggenbuck:mainfrom
Camerooooon wants to merge 5 commits intoJakeRoggenbuck:mainfrom
Conversation
which depend on them to return result.
JakeRoggenbuck
approved these changes
Feb 23, 2024
Owner
JakeRoggenbuck
left a comment
JakeRoggenbuck
left a comment
There was a problem hiding this comment.
Looks good! Merge whenever ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
list_cpus()could throw an error if there is an IO error when fetching non-essential information about the CPU. This PR tries to handle those errors and work around them whenever possible so auto clock speed isn't rendered useless.list_cpus()to return a result and adjust the functions which depend on them to return result.list_cpus()