Skip to content

fix(addon): fail-low daily-volume fallback so orphaned zones can't free-run to 300 L #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
JakeTheRabbit wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(addon): fail-low daily-volume fallback so orphaned zones can't free-run to 300 L #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion addons/f2_control/f2_control/controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,7 +651,12 @@ def _params(self, room, zone):
ec_target_p2=self._zone_num(room, zone, f"ec_target_{sfx}_p2", 6),
p3_emergency_floor=efloor,
p3_emergency_shot=self._zone_num(room, zone, "p3_emergency_shot_size", 2),
max_daily_volume=self._zone_num(room, zone, "max_daily_volume", 300),
# Fallback used ONLY when a zone has no readable max_daily_volume entity — e.g. a zone the
# engine detected from its VWC sensor but the integration never built a cap entity for
# (num_zones < detected zones). Must fail LOW: the integration's own entity maxes at 200 L,
# so the engine can never grant more daily water than the UI can express. Was 300 (above the
# UI max) which let orphaned zones free-run to 300 L/day while wired zones honoured their cap.
max_daily_volume=self._zone_num(room, zone, "max_daily_volume", 150),
field_capacity=fc,
max_ec=self._zone_num(room, zone, "maximum_ec", 9),
stacking_on=self._on(
Expand Down
Loading