fix: move runtime deps out of devDependencies so npx works#7
Open
tavva wants to merge 1 commit intoJamsusMaximus:mainfrom
Open
fix: move runtime deps out of devDependencies so npx works#7tavva wants to merge 1 commit intoJamsusMaximus:mainfrom
tavva wants to merge 1 commit intoJamsusMaximus:mainfrom
Conversation
When installed via npx, devDependencies are not installed. The dev script requires concurrently (root), tsx (server), and vite + @vitejs/plugin-react (client) at runtime, so these must be regular dependencies.
9b9ca6c to
0d118d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Running
npx github:JamsusMaximus/codemapfails becausenpxdoesn't installdevDependencies. Several packages needed at runtime are listed as devDependencies:concurrently(used bydevscript)tsx(used bydevscript viatsx watch)viteand@vitejs/plugin-react(used bydevscript)Errors:
Fix
Move these four packages from
devDependenciestodependenciesin their respectivepackage.jsonfiles.