feat: honor per-column bloom-filter table properties in the Parquet writer - #379
Merged
JanKaul merged 2 commits intoJul 29, 2026
Merged
Conversation
…riter store_parquet_partitioned built its WriterProperties inline with only compression set, so callers had no way to enable Parquet split-block bloom filters. Honor the standard Iceberg property write.parquet.bloom-filter-enabled.column.<name> = true|false per column; properties are already reachable through the existing update_properties transaction op, so no API change is needed. Fixes JanKaul#377.
JanKaul
reviewed
Jul 29, 2026
JanKaul
left a comment
JanKaul
left a comment
Owner
There was a problem hiding this comment.
Thanks for the PR. Generally looks good to me, I left 2 smaller comments
ColumnPath::from(&str) wraps the whole string as a single path segment, so nested columns like my_struct.label_env silently never matched. Split on '.' into path parts instead, and accept the enabled value case-insensitively. Addresses review feedback on JanKaul#379.
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #377.
store_parquet_partitionedbuilt itsWriterPropertiesinline with only compression set, so callers had no way to enable Parquet split-block bloom filters. This honors the standard Iceberg propertywrite.parquet.bloom-filter-enabled.column.<name>=true|falseper column (newWRITE_PARQUET_BLOOM_FILTER_ENABLED_COLUMN_PREFIXconst iniceberg-rust-spec).Table properties are already settable through the existing
update_propertiestransaction op, so no API change is needed — set the property on a table and the next write picks it up. Unrelated properties are ignored; anything but"true"disables the filter for that column.Includes a unit test (
bloom_filter_properties_apply_per_column).Context: SignalDB wants blooms on its materialized label columns for point-lookup pruning (cedricziel/signaldb#731).