Open
Conversation
jankeromnes
reviewed
May 2, 2018
Member
jankeromnes
left a comment
jankeromnes
left a comment
There was a problem hiding this comment.
Exciting, thanks for opening this pull request!
Let's try it with a few projects first before merging. Maybe Firefox, Servo, Thunderbird, Chromium?
| RUN add-apt-repository ppa:git-core/ppa | ||
|
|
||
| # Add source for the latest Mercurial packages. | ||
| RUN add-apt-repository ppa:mercurial-ppa/releases |
Member
There was a problem hiding this comment.
Hmm, this PPA looks badly unmaintained, they still don't support 18.04/bionic (super cool code name by the way!), and their last update was 25 weeks ago even though there have been several mercurial releases since. I think we should really build it from source.
Collaborator
Author
There was a problem hiding this comment.
I've open #195 to tackle with this someday. Meanwhile, we have the latest hg for the current period because 18.04 was just released weeks ago :)
Member
|
Rebased to try this again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will also fix build of Servo, which required a newer harfbuzz version.