Skip to content

Feature/interact event fix#21

Merged
Janschuri merged 1 commit intodevelopfrom
feature/interact-event-fix
Feb 22, 2026
Merged

Feature/interact event fix#21
Janschuri merged 1 commit intodevelopfrom
feature/interact-event-fix

Conversation

@Janschuri
Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings February 21, 2026 20:04
@Janschuri Janschuri changed the base branch from master to develop February 21, 2026 20:04
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes redundant block-level interaction checks from the StorageContainer's item permission validation methods. The changes address an event handling issue by removing EventUtils.isAllowedInteract(player, block) calls while retaining inventory-level permission checks.

Changes:

  • Removed block-level interaction permission checks from isAllowedPutItem and isAllowedTakeItem methods
  • Retained inventory-level permission checks using EventUtils.isAllowedPutItem and EventUtils.isAllowedTakeItem

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chatgpt-codex-connector
Copy link
Copy Markdown

💡 Codex Review

@EventHandler(priority = EventPriority.MONITOR, ignoreCancelled = true)
public void onBlockBreak(BlockBreakEvent event) {

P1 Badge Move break-side effects out of MONITOR phase

This handler now mutates persistent data and schedules storage-map updates during BlockBreakEvent while running at EventPriority.MONITOR. If another plugin cancels the same break later in MONITOR order, the block stays in the world but this listener has already removed Key.STORAGE_CONTAINER/whitelist data and queued a negative inventory diff, leaving the storage index out of sync with the actual chest contents. This is a real risk in plugin stacks where protection or anti-cheat logic also operates at MONITOR.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Janschuri Janschuri merged commit 7fe6ae2 into develop Feb 22, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants