NOJIRA: Merged Faculty Interventions for Pull Request

[jlhart]

1. CREATE TABLES TO HOLD INTERVENTIONS AND EARLY ALERT RELATIONAL LINKS TO INTERVENTIONS

USE [ssp]
GO

/****** Object: Table [dbo].[early_alert_intervention] Script Date: 6/12/2014 12:26:16 PM ******/
SET ANSI_NULLS ON
GO

SET QUOTED_IDENTIFIER ON
GO

CREATE TABLE [dbo].early_alert_intervention(
[id] [uniqueidentifier] NOT NULL,
[name] nvarchar NOT NULL,
[description] nvarchar NULL,
[created_date] [datetime] NOT NULL,
[modified_date] [datetime] NULL,
[created_by] [uniqueidentifier] NOT NULL,
[modified_by] [uniqueidentifier] NULL,
[object_status] [int] NOT NULL,
[sort_order] [smallint] NOT NULL,
CONSTRAINT [PK_EARLY_ALERT_INTERVENTION] PRIMARY KEY CLUSTERED
(
[id] ASC
)WITH (PAD_INDEX = OFF, STATISTICS_NORECOMPUTE = OFF, IGNORE_DUP_KEY = OFF, ALLOW_ROW_LOCKS = ON, ALLOW_PAGE_LOCKS = ON) ON [PRIMARY]
) ON [PRIMARY] TEXTIMAGE_ON [PRIMARY]

GO

ALTER TABLE [dbo].[early_alert_intervention] ADD CONSTRAINT [DF_early_alert_intervention_sort_order] DEFAULT ((0)) FOR [sort_order]
GO

ALTER TABLE [dbo].[early_alert_intervention] WITH CHECK ADD CONSTRAINT [early_alert_intervention_created_by_person_id] FOREIGN KEY([created_by])
REFERENCES [dbo].person
GO

ALTER TABLE [dbo].[early_alert_intervention] CHECK CONSTRAINT [early_alert_intervention_created_by_person_id]
GO

ALTER TABLE [dbo].[early_alert_intervention] WITH CHECK ADD CONSTRAINT [early_alert_intervention_modified_by_person_id] FOREIGN KEY([modified_by])
REFERENCES [dbo].person
GO

ALTER TABLE [dbo].[early_alert_intervention] CHECK CONSTRAINT [early_alert_intervention_modified_by_person_id]

GO

USE [ssp]
GO

/****** Object: Table [dbo].[early_alert_early_alert_intervention] Script Date: 6/16/2014 4:34:55 PM ******/
SET ANSI_NULLS ON
GO

SET QUOTED_IDENTIFIER ON
GO

CREATE TABLE [dbo].[early_alert_early_alert_intervention]([early_alert_id] [uniqueidentifier] NOT NULL,
[early_alert_intervention_id] [uniqueidentifier] NOT NULL,
CONSTRAINT [PK_EARLY_ALERT_EARLY_ALERT_INTERVENTION] PRIMARY KEY CLUSTERED
%28
[early_alert_id] ASC,
[early_alert_intervention_id] ASC
%29WITH %28PAD_INDEX = OFF, STATISTICS_NORECOMPUTE = OFF, IGNORE_DUP_KEY = OFF, ALLOW_ROW_LOCKS = ON, ALLOW_PAGE_LOCKS = ON%29 ON [PRIMARY]) ON [PRIMARY]

GO

ALTER TABLE [dbo].[early_alert_early_alert_intervention] WITH CHECK ADD CONSTRAINT [early_alert_early_alert_intervention_early_alert_id] FOREIGN KEY([early_alert_id])
REFERENCES [dbo].early_alert
GO

ALTER TABLE [dbo].[early_alert_early_alert_intervention] CHECK CONSTRAINT [early_alert_early_alert_intervention_early_alert_id]
GO

ALTER TABLE [dbo].[early_alert_early_alert_intervention] WITH CHECK ADD CONSTRAINT [early_alert_early_alert_intervention_ids] FOREIGN KEY([early_alert_intervention_id])
REFERENCES [dbo].early_alert_intervention
GO

ALTER TABLE [dbo].[early_alert_early_alert_intervention] CHECK CONSTRAINT [early_alert_early_alert_intervention_ids]

GO

Add a column called early_alert_intervention_other_description nvarchar(MAX) to end of early_alert table.

---

2. CREATE ADD/MODIFY FILES BELOW TO HANDLE ADMIN DATA VIEWS:

a. ssp/src/main/webapp/app/store/admin/AdminTreeMenus.js "Add Faculty Interventions Data view to Admin Tool"
b. ssp/src/main/webapp/app/controller/AdminViewController.js "Add earlyAlertInterventionsAllStore data store to AdminViewController"
c. ssp/src/main/webapp/app/model/reference/EarlyAlertIntervention.js "Created NEW File EarlyAlertIntervention.js to extend AbstractReference model"
d. ssp/src/main/webapp/app/store/reference/EarlyAlertInterventions.js "Created NEW File EarlyAlertInterventions.js to extend AbstractReferences data store"
e. ssp/src/main/webapp/app.js "Added Ssp.store.reference.EarlyAlertInterventions, earlyAlertIntervention url path, earlyAlertDetailsInterventionsStore, earlyAlertInterventionsStore & earlyAlertInterventionsAllUnpagedStore"
f. ssp/src/main/java/org/jasig/ssp/dao/reference/EarlyAlertInterventionDao.java "Created EarlyAlertInterventionDao.java for Paging/Sorting/CRUD"
g. ssp/src/main/java/org/jasig/ssp/factory/reference/EarlyAlertInterventionTOFactory.java "Created EarlyAlertInterventionTOFactory.java transfer object factory for converting back and forth from EarlyAlertIntervention models"
h. ssp/src/main/java/org/jasig/ssp/factory/reference/impl/EarlyAlertInterventionTOFactoryImpl.java "Created EarlyAlertInterventionTOFactoryImpl.java"
i. ssp/src/main/java/org/jasig/ssp/model/reference/EarlyAlertIntervention.java "Created EarlyAlertIntervention.java"
j. ssp/src/main/java/org/jasig/ssp/service/impl/EarlyAlertServiceImpl.java "Added EarlyAlertInterventions Faculty Interventions to Early Alert"
k. ssp/src/main/java/org/jasig/ssp/service/reference/EarlyAlertInterventionService.java "Created EarlyAlertInterventionService.java"
l. ssp/src/main/java/org/jasig/ssp/service/reference/impl/EarlyAlertInterventionServiceImpl.java "Created EarlyAlertInterventionServiceImpl.java"
m. ssp/src/main/java/org/jasig/ssp/transferobject/EarlyAlertTO.java "Add EarlyAlertIntervention Faculty Intervention Transfer Object handlers"
n. ssp/src/main/java/org/jasig/ssp/transferobject/reference/EarlyAlertInterventionTO.java "Created EarlyAlertInterventionTO.java"
o. ssp/src/main/java/org/jasig/ssp/web/api/reference/EarlyAlertInterventionController.java "Created EarlyAlertInterventionController.java"
p. ssp/src/main/webapp/all-classes.js "Add EarlyAlertInterventions Faculty Interventions"
q. ssp/src/main/webapp/app/controller/tool/earlyalert/EarlyAlertDetailsViewController.js "Add Faculty Interventions functionality to EA Details Controller"
r. ssp/src/main/webapp/app/controller/tool/earlyalert/EarlyAlertToolViewController.js "Add Faculty Interventions functionality to EA Tool Controller"
s. ssp/src/main/webapp/app/model/reference/EarlyAlertIntervention.js "Created EarlyAlertIntervention.js for Faculty Interventions"
t. ssp/src/main/webapp/app/model/tool/earlyalert/EarlyAlertResponseGrid.js "Add Faculty Interventions fields to Response Grid"
u. ssp/src/main/webapp/app/model/tool/earlyalert/PersonEarlyAlert.js "Add Faculty Interventions fields to Person EA"
v. ssp/src/main/webapp/app/model/tool/earlyalert/PersonEarlyAlertTree.js "Add Faculty Interventions fields to Person EA Tree"
w. ssp/src/main/webapp/app/view/tools/earlyalert/EarlyAlertDetails.js "Add Faculty Interventions data stores to EA Details"
x. ssp/src/main/webapp/js/early-alert-form.js (ADD FIELD VALIDATION HERE) "Added Faculty Interventions to EA form"
y. ssp/src/main/webapp/resources/css/early-alert.css "Add Faculty Interventions Specific CSS"
z. ssp/src/main/webapp/app/util/Constants.js "Add Faculty Interventions Other Constant"
aa. ssp/src/main/webapp/resources/css/report.css "Add Faculty Interventions Specific CSS"
ab. ssp/src/main/webapp/WEB-INF/jsp/ea-form.jsp "Added Faculty Interventions to EA Form"
ac. ssp/src/main/java/org/jasig/ssp/factory/impl/EarlyAlertTOFactoryImpl.java "Add Faculty Interventions Transfer Object and references"
ad. ssp/src/main/java/org/jasig/ssp/model/EarlyAlert.java "Add Faculty Interventions to EA"
ae. ssp/src/main/resources/i18n/messages.properties "Add faculty.interventions field label to properties file"

[dmccallum]

Thanks, Jon.

Three things:

1. In most cases it looks like the patch is being represented as a wholesale replacement of each affected file. Is it possible to resubmit with more targeted changes so it's easier to see what's different? Might be spurious whitespace differences causing the problem?
2. For the db changes, we'll need those to be factored as one or more Liquibase changesets. You'll find many many (many) examples of those in ./src/SSP/src/main/resources/org/jasig/ssp/database/
3. Do you have a screenshot or two to illustrate the resulting UI changes?

[jlhart]

Dan,

1.  I will try to retarget the Pull Request
   

2.  I will work on building some liquibase changesets as I get a chance
   

3.  See below for Screenshots
   

From the Admin Interface you can Add/Edit Interventions as needed:

From the EarlyAlert… (We call them ReachOuts at our institution)

When clicking on the Add/Edit button for Faculty Interventions:

Selected Intervention and Clicked OK

From: dmccallum [mailto:notifications@github.com]
Sent: Thursday, June 26, 2014 6:36 PM
To: Jasig/SSP
Cc: Jonathan Hart
Subject: Re: [SSP] NOJIRA: Merged Faculty Interventions for Pull Request (#8)

Thanks, Jon.

Three things:

1. In most cases it looks like the patch is being represented as a wholesale replacement of each affected file. Is it possible to resubmit with more targeted changes so it's easier to see what's different? Might be spurious whitespace differences causing the problem?
2. For the db changes, we'll need those to be factored as one or more Liquibase changesets. You'll find many many (many) examples of those in ./src/SSP/src/main/resources/org/jasig/ssp/database/
3. Do you have a screenshot or two to illustrate the resulting UI changes?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/8#issuecomment-47288991.