ci: run the three test suites that never ran - #578
Merged
Conversation
JasperFx.SourceGenerator.Tests (19), JasperFx.Events.SourceGenerator.Tests (26) and JasperFx.Aspire.Tests (51) are all in the solution, so `compile` built them and a compile break would fail CI -- but they were in no Nuke test target and no workflow step, so 96 tests never actually executed. A source generator could emit wrong code, or the Aspire integration could regress, without anything going red. Adds TestSourceGenerators (both generator suites) and TestAspire, hangs them off the aggregate Test target, and gives each a workflow step using the same `if: success() || failure()` pattern as the existing suites so one failure does not mask the rest. Framework coverage follows each project rather than the repo default: the two generator test suites pin net9.0 to match the netstandard2.0 generators they host, and the Aspire suite is net10.0-only like JasperFx.Aspire itself. All 96 pass. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
jeremydmiller
force-pushed
the
chore/ci-cover-missing-suites
branch
from
July 29, 2026 11:23
2a0e0b3 to
e7d9250
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #577 (base is
chore/xunit-v3, will retarget tomainonce that merges).The gap
JasperFx.SourceGenerator.Tests(19),JasperFx.Events.SourceGenerator.Tests(26) andJasperFx.Aspire.Tests(51) are all in the solution — socompilebuilt them and a compile break would fail CI — but they were in no Nuke test target and no workflow step. 96 tests built and never executed. A source generator could emit wrong code, or the Aspire integration could regress, without anything going red.Found while baselining test counts for the xunit 3 migration.
Changes
TestSourceGenerators— runs both generator suitesTestAspire— runs the Aspire suiteTesttargetif: ${{ success() || failure() }}pattern so a single failure doesn't mask the remaining suitesFramework coverage follows each project rather than the repo default: the two generator suites pin
net9.0to match thenetstandard2.0generators they host, and the Aspire suite isnet10.0-only likeJasperFx.Aspireitself.Verification
./build.sh testnow runs 11 targets; all green. All 96 previously-dark tests pass.🤖 Generated with Claude Code