chore: drop redundant System.Collections.Immutable reference (NU1510) - #586
Merged
Conversation
Every restore emitted NU1510 for CodegenTests: the PackageReference on System.Collections.Immutable "will not be pruned ... likely unnecessary." CodegenTests does use the type (VariableTests.cs:62 references ImmutableHashSet<string>), but System.Collections.Immutable has been in-box since .NET Core 3.x and this project targets net9.0;net10.0 - the type resolves from the framework with or without the reference. CodegenTests was the only consumer, so the PackageVersion entry in Directory.Packages.props goes with it rather than being left behind as a dangling central version. This was the last remaining restore warning in the solution, so `dotnet restore jasperfx.slnx` is now fully clean - which is what makes future restore warnings actually visible. CodegenTests: 419 passed, matching the baseline. Closes #583 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #583
What
Every restore emitted:
CodegenTestsgenuinely uses the type —src/CodegenTests/VariableTests.cs:62referencesImmutableHashSet<string>— butSystem.Collections.Immutablehas been in-box since .NET Core 3.x, and this project targetsnet9.0;net10.0. The type resolves from the framework either way, so the explicit reference adds nothing.Beyond the one line the issue called for:
CodegenTestswas the only consumer, so the matchingPackageVersionentry inDirectory.Packages.propsis removed too rather than left behind as a dangling central version.Why it matters
This was the last remaining restore warning in the solution now that #579 cleared the MessagePack advisories (and #585 clears the
build/ones).dotnet restore jasperfx.slnxis now completely clean — which is the point: it makes future restore warnings actually visible instead of arriving in a pile of known noise.Verification
419 matches the baseline recorded in #581.
VariableTests.cscompiles unchanged on the framework-provided type.🤖 Generated with Claude Code