Split a match into periods that add back up to the full match length - #79
Merged
Merged
Conversation
Period length was an integer number of minutes, so any duration that did not divide evenly lost the remainder: a 50 minute match in quarters became 4 x 12, and the dialog offered 48 minutes of a 50 minute match while the caption next to it still said 50. Every planned-minutes figure multiplied that truncated number back by 60, so the playing-time table planned everyone short too. Carry the length in seconds instead. Sixty divides by every period count there is, so the split is always exact, and the minutes form stays as a decimal for the two captions that put it on screen. MatchClockReport already worked in seconds for this reason and now asks the model rather than dividing itself. Checked with dotnet build -c Release, dotnet test (395), the Playwright suite (39), and scripts/coverage.sh. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B7iiXxjNQueeYhqQAUKdkr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Period length was an integer number of minutes, so any duration that did not
divide evenly lost the remainder: a 50 minute match in quarters became 4 x 12,
and the dialog offered 48 minutes of a 50 minute match while the caption next
to it still said 50. Every planned-minutes figure multiplied that truncated
number back by 60, so the playing-time table planned everyone short too.
Carry the length in seconds instead. Sixty divides by every period count there
is, so the split is always exact, and the minutes form stays as a decimal for
the two captions that put it on screen. MatchClockReport already worked in
seconds for this reason and now asks the model rather than dividing itself.
Checked with dotnet build -c Release, dotnet test (395), the Playwright suite
(39), and scripts/coverage.sh.
Co-Authored-By: Claude Opus 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01B7iiXxjNQueeYhqQAUKdkr